[PR #1121] [MERGED] Update username regex to string literal with escaped - #8666

New Issue

OVERLORD · 2026-02-07T05:48:12+03:00

OVERLORD commented

2026-02-07 05:48:12 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1121
Author: @LogicalPhallacy
Created: 3/16/2019
Status: ✅ Merged
Merged: 3/17/2019
Merged by: @joshuaboniface

Base: master ← Head: master

📝 Commits (2)

7f0fa74 updated regex to string literal with escaped -
e3dbed1 Update Emby.Server.Implementations/Library/UserManager.cs

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 Emby.Server.Implementations/Library/UserManager.cs (+4 -4)

📄 Description

Changes
The username regex was hard to parse because of the double \ and the unescaped -

Even though it worked this minor fix makes it clearer what it is doing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1121 **Author:** [@LogicalPhallacy](https://github.com/LogicalPhallacy) **Created:** 3/16/2019 **Status:** ✅ Merged **Merged:** 3/17/2019 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`7f0fa74`](https://github.com/jellyfin/jellyfin/commit/7f0fa74467d5f3560addd6cfefbfb2dbd24f4060) updated regex to string literal with escaped - - [`e3dbed1`](https://github.com/jellyfin/jellyfin/commit/e3dbed1c1aff986e51e25ba244a6a6bf52816dbe) Update Emby.Server.Implementations/Library/UserManager.cs ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/UserManager.cs` (+4 -4) </details> ### 📄 Description **Changes** The username regex was hard to parse because of the double \\ and the unescaped - Even though it worked this minor fix makes it clearer what it is doing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 05:48:12 +03:00

OVERLORD closed this issue

2026-02-07 05:48:13 +03:00

OVERLORD referenced this issue

2026-02-07 06:45:03 +03:00

[PR #8666] Fix secondary audio #11815

OVERLORD referenced this issue

2026-02-07 06:47:11 +03:00

[PR #9009] Fix secondary audio #11937

Sign in to join this conversation.