[PR #1065] [MERGED] Don't set status code if response is closed #8633

Closed
opened 2026-02-07 05:47:45 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1065
Author: @cvium
Created: 3/8/2019
Status: Merged
Merged: 3/8/2019
Merged by: @Bond-009

Base: masterHead: closed_response


📝 Commits (1)

  • 3fa43a1 Don't set status code if response is closed

📊 Changes

6 files changed (+19 additions, -50 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/HttpListenerHost.cs (+1 -3)
📝 Emby.Server.Implementations/Services/ServiceExec.cs (+1 -1)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpListener.cs (+4 -1)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpRequest.cs (+2 -5)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpResponse.cs (+10 -27)
📝 MediaBrowser.Model/Services/IRequest.cs (+1 -13)

📄 Description

Changes
Check if headers have already been sent with HasStarted.

Also did some minor cleanup that should help getting rid of websocket-sharp eventually.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1065 **Author:** [@cvium](https://github.com/cvium) **Created:** 3/8/2019 **Status:** ✅ Merged **Merged:** 3/8/2019 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `closed_response` --- ### 📝 Commits (1) - [`3fa43a1`](https://github.com/jellyfin/jellyfin/commit/3fa43a1e08a719e65ed38a57b556be0c0edacaef) Don't set status code if response is closed ### 📊 Changes **6 files changed** (+19 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/HttpListenerHost.cs` (+1 -3) 📝 `Emby.Server.Implementations/Services/ServiceExec.cs` (+1 -1) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpListener.cs` (+4 -1) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpRequest.cs` (+2 -5) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpResponse.cs` (+10 -27) 📝 `MediaBrowser.Model/Services/IRequest.cs` (+1 -13) </details> ### 📄 Description **Changes** Check if headers have already been sent with `HasStarted`. Also did some minor cleanup that should help getting rid of websocket-sharp eventually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:47:45 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8633