starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #990] [MERGED] Fix slow local image validation #8600

New Issue
Closed
opened 2026-02-07 05:47:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:47:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/990
Author: @cvium
Created: 2/24/2019
Status: ✅ Merged
Merged: 2/24/2019
Merged by: @Bond-009

Base: release-10.2.z ← Head: fix_local_image_validation

📝 Commits (2)

  • 6378641 Check for local image directory existence to avoid tons of exceptions
  • 5d56038 Re-add a linebreak that went missing

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs (+7 -0)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+1 -4)

📄 Description

Changes
Added a check for directory existence. Refreshing 240 people just went from ~30 seconds to 0.
Also removed a weird check that swallows exceptions. Let's avoid them instead of handling them silently, eh?
Issues
Related to #951 (but doesn't help the issue that scheduled tasks lock up the server)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/990 **Author:** [@cvium](https://github.com/cvium) **Created:** 2/24/2019 **Status:** ✅ Merged **Merged:** 2/24/2019 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.2.z` ← **Head:** `fix_local_image_validation` --- ### 📝 Commits (2) - [`6378641`](https://github.com/jellyfin/jellyfin/commit/637864101a34b9214395128dcd3f85487d05a348) Check for local image directory existence to avoid tons of exceptions - [`5d56038`](https://github.com/jellyfin/jellyfin/commit/5d560384c2bcc3615f0171c8bb0dd41486a1515f) Re-add a linebreak that went missing ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs` (+7 -0) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+1 -4) </details> ### 📄 Description **Changes** Added a check for directory existence. Refreshing 240 people just went from ~30 seconds to 0. Also removed a weird check that swallows exceptions. Let's avoid them instead of handling them silently, eh? **Issues** Related to #951 (but doesn't help the issue that scheduled tasks lock up the server) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:47:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8600
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?