starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #942] [CLOSED] WIP: Removed CoreAppHost implementation of ApplicationHost #8577

New Issue
Closed
opened 2026-02-07 05:46:51 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:46:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/942
Author: @wtaylor
Created: 2/19/2019
Status: ❌ Closed

Base: master ← Head: remove-CoreAppHost

📝 Commits (1)

  • 6c4b033 Removed CoreAppHost implementation of ApplicationHost

📊 Changes

9 files changed (+44 additions, -84 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+27 -8)
📝 Emby.Server.Implementations/SocketSharp/HttpFile.cs (+1 -1)
📝 Emby.Server.Implementations/SocketSharp/RequestMono.cs (+2 -2)
📝 Emby.Server.Implementations/SocketSharp/SharpWebSocket.cs (+1 -1)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpListener.cs (+2 -2)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpRequest.cs (+5 -5)
📝 Emby.Server.Implementations/SocketSharp/WebSocketSharpResponse.cs (+1 -1)
➖ Jellyfin.Server/CoreAppHost.cs (+0 -61)
📝 Jellyfin.Server/Program.cs (+5 -3)

📄 Description

CoreAppHost didn't provide anything over ApplicationHost and as we'll
only have one implementation of ApplicationHost, it makes sense to
remove abstract and add CoreAppHost's functionality to ApplicationHost.

As a side effect of this, SocketSharp had to be moved to
Server.Implementations which is where it should have been anyway.

Marked WIP to get feedback on the removal of CoreAppHost and to make sure GetEntryAssembly gives us the same result as typeof(CoreAppHost).Assembly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/942 **Author:** [@wtaylor](https://github.com/wtaylor) **Created:** 2/19/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remove-CoreAppHost` --- ### 📝 Commits (1) - [`6c4b033`](https://github.com/jellyfin/jellyfin/commit/6c4b0331a26e712c8c26b4fdb1ae80d547876f88) Removed CoreAppHost implementation of ApplicationHost ### 📊 Changes **9 files changed** (+44 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+27 -8) 📝 `Emby.Server.Implementations/SocketSharp/HttpFile.cs` (+1 -1) 📝 `Emby.Server.Implementations/SocketSharp/RequestMono.cs` (+2 -2) 📝 `Emby.Server.Implementations/SocketSharp/SharpWebSocket.cs` (+1 -1) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpListener.cs` (+2 -2) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpRequest.cs` (+5 -5) 📝 `Emby.Server.Implementations/SocketSharp/WebSocketSharpResponse.cs` (+1 -1) ➖ `Jellyfin.Server/CoreAppHost.cs` (+0 -61) 📝 `Jellyfin.Server/Program.cs` (+5 -3) </details> ### 📄 Description CoreAppHost didn't provide anything over ApplicationHost and as we'll only have one implementation of ApplicationHost, it makes sense to remove abstract and add CoreAppHost's functionality to ApplicationHost. As a side effect of this, SocketSharp had to be moved to Server.Implementations which is where it should have been anyway. Marked WIP to get feedback on the removal of CoreAppHost and to make sure GetEntryAssembly gives us the same result as typeof(CoreAppHost).Assembly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:46:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?