[PR #848] [MERGED] Minor changes to reduce allocations #8530

Closed
opened 2026-02-07 05:45:58 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/848
Author: @Bond-009
Created: 2/9/2019
Status: Merged
Merged: 2/20/2019
Merged by: @joshuaboniface

Base: masterHead: perf


📝 Commits (10+)

📊 Changes

21 files changed (+301 additions, -302 deletions)

View changed files

📝 Emby.Server.Implementations/Data/BaseSqliteRepository.cs (+2 -25)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+139 -146)
📝 Emby.Server.Implementations/HttpServer/HttpResultFactory.cs (+17 -17)
📝 Emby.Server.Implementations/HttpServer/StreamWriter.cs (+2 -6)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+21 -23)
📝 Emby.Server.Implementations/Library/UserManager.cs (+2 -2)
📝 Emby.Server.Implementations/LiveTv/LiveTvManager.cs (+1 -1)
📝 Emby.Server.Implementations/Serialization/JsonSerializer.cs (+21 -0)
📝 Jellyfin.Server/SocketSharp/WebSocketSharpRequest.cs (+32 -35)
📝 MediaBrowser.Api/BaseApiService.cs (+23 -9)
📝 MediaBrowser.Api/UserLibrary/ArtistsService.cs (+1 -1)
📝 MediaBrowser.Api/UserLibrary/BaseItemsByNameService.cs (+2 -2)
📝 MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs (+3 -5)
📝 MediaBrowser.Api/UserLibrary/GenresService.cs (+1 -1)
📝 MediaBrowser.Api/UserLibrary/ItemsService.cs (+7 -10)
📝 MediaBrowser.Api/UserLibrary/MusicGenresService.cs (+1 -1)
📝 MediaBrowser.Api/UserLibrary/PersonsService.cs (+3 -3)
📝 MediaBrowser.Api/UserLibrary/StudiosService.cs (+1 -1)
📝 MediaBrowser.Controller/Library/ILibraryManager.cs (+7 -7)
📝 MediaBrowser.Controller/Persistence/IItemRepository.cs (+7 -7)

...and 1 more files

📄 Description

Reduces stress on the GC


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/848 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 2/9/2019 **Status:** ✅ Merged **Merged:** 2/20/2019 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `perf` --- ### 📝 Commits (10+) - [`64d5ec1`](https://github.com/jellyfin/jellyfin/commit/64d5ec12e260758c4a7b3e9df85212b51dab8444) Use HashSets for increased perf - [`41fb1e5`](https://github.com/jellyfin/jellyfin/commit/41fb1e510616e42490354b8912d2117b836ab822) Tuple -> ValueTuple - [`3e6819c`](https://github.com/jellyfin/jellyfin/commit/3e6819c718a45b44eb3f84439d118ad849ccffa8) Don't clone lists - [`7722cb3`](https://github.com/jellyfin/jellyfin/commit/7722cb3ffab5b8330b34fb27608ba9ff35f6ce81) Some Lists -> IEnumerable - [`9dba930`](https://github.com/jellyfin/jellyfin/commit/9dba930a85bc606840918639f4cd0b80c1e1eb2b) Warn faster for slow requests - [`da9418c`](https://github.com/jellyfin/jellyfin/commit/da9418c1b2348a68bd7a554462c8f355eacb6131) Useless copy - [`8d98885`](https://github.com/jellyfin/jellyfin/commit/8d98885cdae15cc9865e0984e4270ee4a8d9d2db) Less string allocations - [`585b520`](https://github.com/jellyfin/jellyfin/commit/585b5201f1b3b34427b1b8f8e03258feff651516) Last bits - [`ea446fd`](https://github.com/jellyfin/jellyfin/commit/ea446fd4a3c41c1350a4faf34044bdf808d334fd) Revert back to netcoreapp2.1 - [`3f13851`](https://github.com/jellyfin/jellyfin/commit/3f13851be54ce97df72fc27a15ee74c7600e38b1) Address comments ### 📊 Changes **21 files changed** (+301 additions, -302 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/BaseSqliteRepository.cs` (+2 -25) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+139 -146) 📝 `Emby.Server.Implementations/HttpServer/HttpResultFactory.cs` (+17 -17) 📝 `Emby.Server.Implementations/HttpServer/StreamWriter.cs` (+2 -6) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+21 -23) 📝 `Emby.Server.Implementations/Library/UserManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/LiveTv/LiveTvManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/Serialization/JsonSerializer.cs` (+21 -0) 📝 `Jellyfin.Server/SocketSharp/WebSocketSharpRequest.cs` (+32 -35) 📝 `MediaBrowser.Api/BaseApiService.cs` (+23 -9) 📝 `MediaBrowser.Api/UserLibrary/ArtistsService.cs` (+1 -1) 📝 `MediaBrowser.Api/UserLibrary/BaseItemsByNameService.cs` (+2 -2) 📝 `MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs` (+3 -5) 📝 `MediaBrowser.Api/UserLibrary/GenresService.cs` (+1 -1) 📝 `MediaBrowser.Api/UserLibrary/ItemsService.cs` (+7 -10) 📝 `MediaBrowser.Api/UserLibrary/MusicGenresService.cs` (+1 -1) 📝 `MediaBrowser.Api/UserLibrary/PersonsService.cs` (+3 -3) 📝 `MediaBrowser.Api/UserLibrary/StudiosService.cs` (+1 -1) 📝 `MediaBrowser.Controller/Library/ILibraryManager.cs` (+7 -7) 📝 `MediaBrowser.Controller/Persistence/IItemRepository.cs` (+7 -7) _...and 1 more files_ </details> ### 📄 Description Reduces stress on the GC --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:45:58 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8530