starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #727] [MERGED] Change default aspect ratio to 2/3 from 0 #8469

New Issue
Closed
opened 2026-02-07 05:44:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:44:49 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/727
Author: @cvium
Created: 1/27/2019
Status: ✅ Merged
Merged: 1/27/2019
Merged by: @andrewrabert

Base: master ← Head: change_default_aspect

📝 Commits (1)

  • 0e61793 Change default aspect ratio to 2/3 from 0

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 MediaBrowser.Controller/Entities/BaseItem.cs (+1 -1)

📄 Description

Changes
Changed BaseItem's default aspect ratio to 2/3, which was the pre-GPL value. It's used in a division, where 0 is obviously a terrible default

Issues


[21:58:54] [ERR] Error processing request
System.OverflowException: Value was either too large or too small for an Int32.
at System.Convert.ToInt32(Double value)
at MediaBrowser.Controller.Drawing.ImageHelper.GetSizeEstimate(ImageProcessingOptions options) in /Users/me/RiderProjects/jellyfin/MediaBrowser.Controller/Drawing/ImageHelper.cs:line 37

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/727 **Author:** [@cvium](https://github.com/cvium) **Created:** 1/27/2019 **Status:** ✅ Merged **Merged:** 1/27/2019 **Merged by:** [@andrewrabert](https://github.com/andrewrabert) **Base:** `master` ← **Head:** `change_default_aspect` --- ### 📝 Commits (1) - [`0e61793`](https://github.com/jellyfin/jellyfin/commit/0e617933f630d444bc8cefc28583feae2eaa8a61) Change default aspect ratio to 2/3 from 0 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+1 -1) </details> ### 📄 Description **Changes** Changed BaseItem's default aspect ratio to 2/3, which was the pre-GPL value. It's used in a division, where 0 is obviously a terrible default **Issues** ``` [21:58:54] [ERR] Error processing request System.OverflowException: Value was either too large or too small for an Int32. at System.Convert.ToInt32(Double value) at MediaBrowser.Controller.Drawing.ImageHelper.GetSizeEstimate(ImageProcessingOptions options) in /Users/me/RiderProjects/jellyfin/MediaBrowser.Controller/Drawing/ImageHelper.cs:line 37 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:44:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?