starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #675] [CLOSED] A fix for incorrect segment_time_delta given to ffmpeg #8439

New Issue
Closed
opened 2026-02-07 05:44:12 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 05:44:12 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/675
Author: @Tthecreator
Created: 1/23/2019
Status: ❌ Closed

Base: dev ← Head: ffmpeg-bugs-delta_time

📝 Commits (10+)

  • 2d90df9 Presenting a fix for incorrect segment_time_delta given to ffmpeg #674
  • 5646efb Revert "removed excess newlines"
  • eae5117 Revert "Set EnableRaisingEvents correctly for SubtitleEncoder"
  • efeebe2 Presenting a fix for incorrect segment_time_delta given to ffmpeg #674
  • ee8566d Move the definition to base of base class, give it a shorter name
  • e566cdf Merge branch 'ffmpeg-bugs-delta_time' of https://github.com/hawken93/jellyfin into hawken93-ffmpeg-bugs-delta_time
  • 2a94bea Merge pull request #3 from Tthecreator/hawken93-ffmpeg-bugs-delta_time
  • 4cfe1b7 Revert "Merge branch 'ffmpeg-bugs-delta_time' of https://github.com/hawken93/jellyfin into hawken93-ffmpeg-bugs-delta_time"
  • 38a57ce Revert "Hawken93 ffmpeg bugs delta time"
  • bbb2e76 Merge pull request #4 from Tthecreator/revert-3-hawken93-ffmpeg-bugs-delta_time

📊 Changes

28 files changed (+395 additions, -533 deletions)

View changed files

📝 .dockerignore (+0 -2)
📝 .gitmodules (+3 -0)
📝 CONTRIBUTORS.md (+1 -2)
📝 Dockerfile.arm (+3 -6)
➖ Dockerfile.arm64 (+0 -33)
📝 Emby.Photos/Emby.Photos.csproj (+1 -4)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+1 -13)
📝 Emby.Server.Implementations/Diagnostics/CommonProcess.cs (+11 -7)
📝 MediaBrowser.Api/Playback/BaseStreamingService.cs (+7 -0)
📝 MediaBrowser.Api/Playback/Hls/DynamicHlsService.cs (+29 -4)
📝 MediaBrowser.Api/Playback/MediaInfoService.cs (+4 -16)
📝 MediaBrowser.Api/Playback/StreamState.cs (+1 -1)
📝 MediaBrowser.Api/Playback/UniversalAudioService.cs (+2 -24)
📝 MediaBrowser.Api/Subtitles/SubtitleService.cs (+2 -7)
📝 MediaBrowser.Controller/Entities/Audio/MusicAlbum.cs (+1 -1)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs (+2 -2)
📝 MediaBrowser.Model/Dlna/AudioOptions.cs (+10 -10)
📝 MediaBrowser.Model/Dlna/ConditionProcessor.cs (+11 -13)
📝 MediaBrowser.Model/Dlna/DeviceProfile.cs (+9 -3)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+274 -184)

...and 8 more files

📄 Description

Changes
There seem to be a lot of issues that have problems with either negative numbers, or numbers with wrong decimal points given to ffmpeg as segment_time_delta argument. This may be due to string conversions working differently between systems and configurations. I've created a NumberFormatInfo class that should better define what the segment_time_delta parameter for ffmpeg.

Issues
#674

Things to consider
If this problem also exists on other arguments, my code may have to be rewritten a little bit.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/675 **Author:** [@Tthecreator](https://github.com/Tthecreator) **Created:** 1/23/2019 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `ffmpeg-bugs-delta_time` --- ### 📝 Commits (10+) - [`2d90df9`](https://github.com/jellyfin/jellyfin/commit/2d90df94020f24843645acfc2876d24ca8d8e407) Presenting a fix for incorrect segment_time_delta given to ffmpeg #674 - [`5646efb`](https://github.com/jellyfin/jellyfin/commit/5646efb0ce6ee60e24c6d60fbdc5d32a80e3c436) Revert "removed excess newlines" - [`eae5117`](https://github.com/jellyfin/jellyfin/commit/eae51170ea85c0a1a85aa11c12b71679474d8b3d) Revert "Set EnableRaisingEvents correctly for SubtitleEncoder" - [`efeebe2`](https://github.com/jellyfin/jellyfin/commit/efeebe2be7ecd3c4c78f584c82363505855bf90e) Presenting a fix for incorrect segment_time_delta given to ffmpeg #674 - [`ee8566d`](https://github.com/jellyfin/jellyfin/commit/ee8566de013ada1908c8d7aea0eb73f39390f0f4) Move the definition to base of base class, give it a shorter name - [`e566cdf`](https://github.com/jellyfin/jellyfin/commit/e566cdf78c3ef30cad4e188f1984afa8ee78d0f4) Merge branch 'ffmpeg-bugs-delta_time' of https://github.com/hawken93/jellyfin into hawken93-ffmpeg-bugs-delta_time - [`2a94bea`](https://github.com/jellyfin/jellyfin/commit/2a94bea0d1b3a1bbf206ee91cba900c06d05e526) Merge pull request #3 from Tthecreator/hawken93-ffmpeg-bugs-delta_time - [`4cfe1b7`](https://github.com/jellyfin/jellyfin/commit/4cfe1b790afb416d4e2efa887d2d236ba4b330c1) Revert "Merge branch 'ffmpeg-bugs-delta_time' of https://github.com/hawken93/jellyfin into hawken93-ffmpeg-bugs-delta_time" - [`38a57ce`](https://github.com/jellyfin/jellyfin/commit/38a57cef5b72b5f9560f8258089fb79b1b71b25b) Revert "Hawken93 ffmpeg bugs delta time" - [`bbb2e76`](https://github.com/jellyfin/jellyfin/commit/bbb2e7653116b25901efc6d5fb30bec0fd0d463a) Merge pull request #4 from Tthecreator/revert-3-hawken93-ffmpeg-bugs-delta_time ### 📊 Changes **28 files changed** (+395 additions, -533 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+0 -2) 📝 `.gitmodules` (+3 -0) 📝 `CONTRIBUTORS.md` (+1 -2) 📝 `Dockerfile.arm` (+3 -6) ➖ `Dockerfile.arm64` (+0 -33) 📝 `Emby.Photos/Emby.Photos.csproj` (+1 -4) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+1 -13) 📝 `Emby.Server.Implementations/Diagnostics/CommonProcess.cs` (+11 -7) 📝 `MediaBrowser.Api/Playback/BaseStreamingService.cs` (+7 -0) 📝 `MediaBrowser.Api/Playback/Hls/DynamicHlsService.cs` (+29 -4) 📝 `MediaBrowser.Api/Playback/MediaInfoService.cs` (+4 -16) 📝 `MediaBrowser.Api/Playback/StreamState.cs` (+1 -1) 📝 `MediaBrowser.Api/Playback/UniversalAudioService.cs` (+2 -24) 📝 `MediaBrowser.Api/Subtitles/SubtitleService.cs` (+2 -7) 📝 `MediaBrowser.Controller/Entities/Audio/MusicAlbum.cs` (+1 -1) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs` (+2 -2) 📝 `MediaBrowser.Model/Dlna/AudioOptions.cs` (+10 -10) 📝 `MediaBrowser.Model/Dlna/ConditionProcessor.cs` (+11 -13) 📝 `MediaBrowser.Model/Dlna/DeviceProfile.cs` (+9 -3) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+274 -184) _...and 8 more files_ </details> ### 📄 Description **Changes** There seem to be a lot of issues that have problems with either negative numbers, or numbers with wrong decimal points given to ffmpeg as segment_time_delta argument. This may be due to string conversions working differently between systems and configurations. I've created a NumberFormatInfo class that should better define what the segment_time_delta parameter for ffmpeg. **Issues** #674 **Things to consider** If this problem also exists on other arguments, my code may have to be rewritten a little bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 05:44:12 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#8439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?