[PR #391] [MERGED] Remove old ImageEncoders (ImageMagick & Drawing.Net) #8298

New Issue

OVERLORD · 2026-02-07T05:41:35+03:00

OVERLORD commented

2026-02-07 05:41:35 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/391
Author: @EraYaN
Created: 1/3/2019
Status: ✅ Merged
Merged: 1/5/2019
Merged by: @JustAMan

Base: dev ← Head: remove-old-imageencoders

📝 Commits (2)

49fe947 Removed all old and unused ImageEncoders.
99ed70f Removed last using.

📊 Changes

146 files changed (+20 additions, -12228 deletions)

View changed files

➖ Emby.Drawing.ImageMagick/Emby.Drawing.ImageMagick.csproj (+0 -19)
➖ Emby.Drawing.ImageMagick/ImageHelpers.cs (+0 -43)
➖ Emby.Drawing.ImageMagick/ImageMagickEncoder.cs (+0 -354)
➖ Emby.Drawing.ImageMagick/PercentPlayedDrawer.cs (+0 -40)
➖ Emby.Drawing.ImageMagick/PlayedIndicatorDrawer.cs (+0 -125)
➖ Emby.Drawing.ImageMagick/Properties/AssemblyInfo.cs (+0 -36)
➖ Emby.Drawing.ImageMagick/StripCollageBuilder.cs (+0 -202)
➖ Emby.Drawing.ImageMagick/UnplayedCountIndicator.cs (+0 -73)
➖ Emby.Drawing.ImageMagick/fonts/robotoregular.ttf (+0 -0)
➖ Emby.Drawing.Net/DynamicImageHelpers.cs (+0 -110)
➖ Emby.Drawing.Net/Emby.Drawing.Net.csproj (+0 -17)
➖ Emby.Drawing.Net/GDIImageEncoder.cs (+0 -282)
➖ Emby.Drawing.Net/ImageExtensions.cs (+0 -217)
➖ Emby.Drawing.Net/ImageHelpers.cs (+0 -43)
➖ Emby.Drawing.Net/PercentPlayedDrawer.cs (+0 -34)
➖ Emby.Drawing.Net/PlayedIndicatorDrawer.cs (+0 -32)
➖ Emby.Drawing.Net/Properties/AssemblyInfo.cs (+0 -36)
➖ Emby.Drawing.Net/UnplayedCountIndicator.cs (+0 -50)
➖ Emby.Drawing.Net/empty.png (+0 -0)
➖ ImageMagickSharp/.gitignore (+0 -235)

...and 80 more files

📄 Description

The fallback would never actually fallback. The only thing could be the remove the Assembly after build, and that crashed it regardless. Hence the step to remove the ImageMagick ImageEncoder.

It was a build time fallback at best. Skia works on all platforms that are intended to be supported.

Finally also all those dlls gone from the repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/391 **Author:** [@EraYaN](https://github.com/EraYaN) **Created:** 1/3/2019 **Status:** ✅ Merged **Merged:** 1/5/2019 **Merged by:** [@JustAMan](https://github.com/JustAMan) **Base:** `dev` ← **Head:** `remove-old-imageencoders` --- ### 📝 Commits (2) - [`49fe947`](https://github.com/jellyfin/jellyfin/commit/49fe9478f3016063eabf7cdf3f29bb8cec34889c) Removed all old and unused ImageEncoders. - [`99ed70f`](https://github.com/jellyfin/jellyfin/commit/99ed70f7ee1d44b3d5e241896abc5460ff09784f) Removed last using. ### 📊 Changes **146 files changed** (+20 additions, -12228 deletions) <details> <summary>View changed files</summary> ➖ `Emby.Drawing.ImageMagick/Emby.Drawing.ImageMagick.csproj` (+0 -19) ➖ `Emby.Drawing.ImageMagick/ImageHelpers.cs` (+0 -43) ➖ `Emby.Drawing.ImageMagick/ImageMagickEncoder.cs` (+0 -354) ➖ `Emby.Drawing.ImageMagick/PercentPlayedDrawer.cs` (+0 -40) ➖ `Emby.Drawing.ImageMagick/PlayedIndicatorDrawer.cs` (+0 -125) ➖ `Emby.Drawing.ImageMagick/Properties/AssemblyInfo.cs` (+0 -36) ➖ `Emby.Drawing.ImageMagick/StripCollageBuilder.cs` (+0 -202) ➖ `Emby.Drawing.ImageMagick/UnplayedCountIndicator.cs` (+0 -73) ➖ `Emby.Drawing.ImageMagick/fonts/robotoregular.ttf` (+0 -0) ➖ `Emby.Drawing.Net/DynamicImageHelpers.cs` (+0 -110) ➖ `Emby.Drawing.Net/Emby.Drawing.Net.csproj` (+0 -17) ➖ `Emby.Drawing.Net/GDIImageEncoder.cs` (+0 -282) ➖ `Emby.Drawing.Net/ImageExtensions.cs` (+0 -217) ➖ `Emby.Drawing.Net/ImageHelpers.cs` (+0 -43) ➖ `Emby.Drawing.Net/PercentPlayedDrawer.cs` (+0 -34) ➖ `Emby.Drawing.Net/PlayedIndicatorDrawer.cs` (+0 -32) ➖ `Emby.Drawing.Net/Properties/AssemblyInfo.cs` (+0 -36) ➖ `Emby.Drawing.Net/UnplayedCountIndicator.cs` (+0 -50) ➖ `Emby.Drawing.Net/empty.png` (+0 -0) ➖ `ImageMagickSharp/.gitignore` (+0 -235) _...and 80 more files_ </details> ### 📄 Description The fallback would never actually fallback. The only thing could be the remove the Assembly after build, and that crashed it regardless. Hence the step to remove the ImageMagick ImageEncoder. It was a build time fallback at best. Skia works on all platforms that are intended to be supported. Finally also all those dlls gone from the repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 05:41:35 +03:00

OVERLORD closed this issue

2026-02-07 05:41:36 +03:00

OVERLORD referenced this issue

2026-02-07 06:42:37 +03:00

[PR #8298] Added handling of streams of type "data" #11681

OVERLORD referenced this issue

2026-02-07 06:43:24 +03:00

[PR #8480] Revert "Merge pull request #8298 from lomion0815/fix-data-stream" #11723

OVERLORD referenced this issue

2026-02-07 06:44:58 +03:00

[PR #8649] Revert "Revert "Merge pull request #8298 from lomion0815/fix-data-stream"" #11810