mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-25 06:03:37 +03:00
Understand DLNA Code #80
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anthonylavado on GitHub (Dec 14, 2018).
As part of #126, some changes were made regarding the naming of the DLNA server. @BnMcG made an interesting observation as part of his changes:
40c95d9804/Emby.Dlna/Api/DlnaServerService.cs (L226-L230)We should really try to understand what's happening there, and if we need to make any changes.
@LeoVerto commented on GitHub (Dec 14, 2018):
Looks like it somehow strips mediabrowser/emby/jellyfin from the path but I'm not really proficient in .NET and the documentation for PathInfo seems really lacking to me.
@BnMcG commented on GitHub (Dec 14, 2018):
I'll take a look at the DLNA spec and see if that makes it clearer
-------- Original Message --------
On 14 Dec 2018, 08:03, LeoVerto wrote:
@PrplHaz4 commented on GitHub (Dec 14, 2018):
It looks like it's trying to get the resource id (TargetServerUuid) out of the path - it's used in this method:
40c95d9804/Emby.Dlna/Api/DlnaServerService.cs (L208)Since we control the servers now, theoretically maintaining BC here should not be needed, as our server root will likely only ever be "jellyfin".
Lazy test here would probably be just logging every output of that method when a DLNA share is accessed.
@andrewrabert commented on GitHub (Dec 22, 2018):
This issue, as it is currently titled, is not a valid issue. Understanding is important, but how do we define this as done? The answer to that question, if there is one, validates the existence of this card.
Please reopen if modified to be actionable.
@anthonylavado commented on GitHub (Dec 22, 2018):
@nvllsvm - Sorry about that. Perhaps it should have been: “Do we need to keep these lines for Emby and MediaBrowser”, but I’m fine leaving them in as is. It doesn’t seem to hurt us.