mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[Issue]: Hearing impaired subtitle stream indicator is too sensitive leading to false detections #5963
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mikewesten on GitHub (Jun 7, 2024).
Originally assigned to: @Bond-009 on GitHub.
Please describe your bug
There's an issue with the new subtitle stream indicator code #7379
It's falsely displaying the subtitle label for hearing impaired when the letters "HI", "CC", or "SDH" are found within any word descriptions (as in, they're present within a word by mere coincidence).
Reproduction Steps
Name a subtitle giving it a description using any word that has the letters "hi" in it.
Example:
movie.name.year.date.Subs for Chinese Audio.eng.srtInstead of displaying the intended descriptive label "Subs for Chinese Audio", the subtitle indicator displays the "Hearing Impaired" label instead.
Quickly confirm this is what it is doing by changing the .srt filename to
movie.name.year.date.Subs for C h i n e s e Audio.eng.srtand rescanning.Now the indicator displays the label as "Subs for C h i n e s e Audio" instead of "Hearing Impaired".
Jellyfin Version
10.9.0
if other:
No response
Environment
Jellyfin logs
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@jellyfin-bot commented on GitHub (Jun 7, 2024):
Hi, it seems like your issue report has the following item(s) that need to be addressed:
This is an automated message, currently under testing. Please file an issue here if you encounter any problems.
@felix920506 commented on GitHub (Aug 30, 2024):
should be fixed by #12026