starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[Issue]: OS name endpoint was removed and the VPP tonemap options disappears #5614

New Issue
Closed
opened 2026-02-07 02:00:18 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-07 02:00:18 +03:00
Owner
Copy Link

Originally created by @nyanmisaka on GitHub (Apr 18, 2024).

Please describe your bug

The OS name endpoint was removed in #9175 since it was considered useless, but the VPP tonemap options in the web client relies on this to choose to display on Linux and hide on Windows.

        if (systemInfo.OperatingSystem.toLowerCase() === 'linux' && (this.value == 'qsv' || this.value == 'vaapi')) {
            page.querySelector('.vppTonemappingOptions').classList.remove('hide');
        } else {
            page.querySelector('.vppTonemappingOptions').classList.add('hide');
        }

In the future, cross-platform Vulkan and VA-API HWA may also need OS name to display the corresponding web options. So I'm not sure if it's necessary to revert this change.

Reproduction Steps

  1. In Jellyfin server Linux/Docker builds
  2. Go to Dashboard -> Playback
  3. Select Intel QuickSync HWA
  4. You can see the VPP tonemap options are missing

Jellyfin Version

Unstable (master branch)

if other:

No response

Environment

- OS: Linux
- Linux Kernel: Any
- Virtualization: None and Docker
- Clients: Web client
- Browser: Any
- FFmpeg Version: Not used
- Playback Method: Not used
- Hardware Acceleration: Not used
- GPU Model: Not used
- Plugins: Not used
- Reverse Proxy: Not used
- Base URL: Not used
- Networking: Localhost
- Storage: Local

Jellyfin logs

This error is not shown in the server log

FFmpeg logs

This error is not shown in the ffmpeg log

Please attach any browser or client logs here

This error is not shown in the browser log

Please attach any screenshots here

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
Originally created by @nyanmisaka on GitHub (Apr 18, 2024). ### Please describe your bug The OS name endpoint was removed in [#9175](https://github.com/jellyfin/jellyfin/pull/9175) since it was considered useless, but the VPP tonemap options in the [web client relies on this](https://github.com/jellyfin/jellyfin-web/blob/17b1a757ddcfd317f34881628c7ca79b14481db7/src/controllers/dashboard/encodingsettings.js#L234) to choose to display on Linux and hide on Windows. ```js if (systemInfo.OperatingSystem.toLowerCase() === 'linux' && (this.value == 'qsv' || this.value == 'vaapi')) { page.querySelector('.vppTonemappingOptions').classList.remove('hide'); } else { page.querySelector('.vppTonemappingOptions').classList.add('hide'); } ``` In the future, cross-platform Vulkan and VA-API HWA may also need OS name to display the corresponding web options. So I'm not sure if it's necessary to revert this change. ### Reproduction Steps 1. In Jellyfin server Linux/Docker builds 2. Go to Dashboard -> Playback 3. Select Intel QuickSync HWA 4. You can see the VPP tonemap options are missing ### Jellyfin Version Unstable (master branch) ### if other: _No response_ ### Environment ```markdown - OS: Linux - Linux Kernel: Any - Virtualization: None and Docker - Clients: Web client - Browser: Any - FFmpeg Version: Not used - Playback Method: Not used - Hardware Acceleration: Not used - GPU Model: Not used - Plugins: Not used - Reverse Proxy: Not used - Base URL: Not used - Networking: Localhost - Storage: Local ``` ### Jellyfin logs ```shell This error is not shown in the server log ``` ### FFmpeg logs ```shell This error is not shown in the ffmpeg log ``` ### Please attach any browser or client logs here This error is not shown in the browser log ### Please attach any screenshots here ![image](https://github.com/jellyfin/jellyfin/assets/14953024/b9c9e29c-aba5-4ec4-a016-8d8f1f894fc0) ### Code of Conduct - [X] I agree to follow this project's Code of Conduct
OVERLORD added the bugconfirmed labels 2026-02-07 02:00:18 +03:00
OVERLORD commented 2026-02-07 02:00:20 +03:00
Author
Owner
Copy Link

@jellyfin-bot commented on GitHub (Apr 18, 2024):

Hi, it seems like your issue report has the following item(s) that need to be addressed:

  • You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

@jellyfin-bot commented on GitHub (Apr 18, 2024): Hi, it seems like your issue report has the following item(s) that need to be addressed: - You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log. This is an automated message, currently under testing. Please file an issue [here](https://github.com/jellyfin/jellyfin-triage-scripts/issues) if you encounter any problems.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label bug confirmed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#5614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?