mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
FFMPEG is sometimes not found on Windows #556
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LogicalPhallacy on GitHub (Apr 2, 2019).
Originally assigned to: @LogicalPhallacy on GitHub.
Describe the bug
On the Jellyfin 10.3-RC jellyfin seems unable to find ffmpeg (shipped with it) without manual intervention
To Reproduce
Expected behavior
Jellyfin should search in the path, in its own directory, and in any common install locations for ffmpeg (that last one isn't really a thing on windows)
System (please complete the following information):
@ploughpuff commented on GitHub (Apr 3, 2019):
What do you mean by "shipped with it" please?
The search order is xml config file, command line switch and finally $PATH.
Out of interest, where is the required binary located?
@LogicalPhallacy commented on GitHub (Apr 3, 2019):
We ship the windows builds of Jellyfin with a zeranoe ffmpeg build in the
jellyfin directory. The new search order prevents that included binary from
being detected which causes problems for windows installs. I am working on
a PR to append the jellyfin install directory where we keep that binary by
default on windows to the PATH variable from within the context of the
Jellyfin process which should resolve the issue in a nonimpactful way that
is compliant with how Windows and *Nix operate.
On Tue, Apr 2, 2019 at 2:29 PM ploughpuff notifications@github.com wrote:
@Bond-009 commented on GitHub (Apr 3, 2019):
IMO the proper solution is just passing the exe name and let windows figure out if it’s in PATH or the current dir.
@ploughpuff commented on GitHub (Apr 3, 2019):
Well, the current approach was taken to allow the full path to the ffmpeg binary to be traced in the log file and appear on the transcode UI page.
@daves00 commented on GitHub (Apr 3, 2019):
On a Windows platform search order should always start with it's own directory. This was specified by M$ quite some while ago.
@joshuaboniface commented on GitHub (Apr 20, 2019):
Should be fixed in 10.3.0 release.