mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[Issue]: Libraries thumbnails should respect parental guidance settings for user #5073
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @csaavedra on GitHub (Sep 5, 2023).
Please describe your bug
I have added a user with parental guidance restriction set to TV-Y7. When opening a client with that user, Jellyfin correctly shows only the shows and movies that are rated TV-Y7 or less. However, the library thumbnail (the backdrop under "Movies", "Series", etc) is showing content that is MA or PG. Of course, those shows/movies are not visible, but the image used there should only come from media that is allowed for the user.
Jellyfin Version
10.8.z
if other:
No response
Environment
No response
Jellyfin logs
No response
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@SamJongenelen commented on GitHub (Oct 8, 2023):
I am not yet familiar enough with JF to know for sure, but it looks like this line is a relevant TODO.
It now uses a hardcoded
MaxParentalRatingof 10. Setting the hardcodedMaxParentalRatingeven lower would make us miss out on pretty cool images by default, so that doesnt sound like a good idea.This splashscreen code is a background process triggered by the
LibraryManagerand so it has no context of a User when ran. I guess this is why the TODO is made; the Splashscreens and thumbs are not user based.We could program a system setting - not a user setting - to set the
MaxParentalRatingused per system?@csaavedra commented on GitHub (Oct 9, 2023):
That sounds like a workaround, dunno. I'm only a user of Jellyfin, so not an authoritative figure around here in any way, but in my experience working on other projects just adding a setting to work around a limitation is usually a poor choice, as these tend to pile up. I'd advocate for making sure that the splashscreen/library manager are user-aware.
@srcrist commented on GitHub (Oct 19, 2023):
Closing this issue as a duplicate of https://github.com/jellyfin/jellyfin/issues/10116. These images are actually pre-generated and are not generated on a per-user basis at all. While waiting on such a feature to be added, if ever, server administrators can always set a static image for the library that is not generated by the collage process at all, if they wish.