mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[Issue]: Whitelisted assemblies not included from manifest #4935
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AmbulantRex on GitHub (Jul 1, 2023).
Please describe your bug
A whitelist of assemblies may be added to a plugin to prevent loading DLLs that may contain native interop. This relates to discussion #9523 and the changes were applied in PR #9564.
It appears that this is due to the reconciliation of the local manifest against the installation manifest. When the reconciliation occurs, only the local manifest is considered which contains an empty array by default and so the installation manifest is clobbered immediately.
Steps to reproduce:
meta.jsonin the plugin folder to see that the assemblies array is empty after install.Jellyfin Version
10.8.z
if other:
No response
Environment
Jellyfin logs
No response
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@AmbulantRex commented on GitHub (Jul 16, 2023):
Based on our previous discussions, I think we concluded that the
meta.jsonshould be included with necessary assemblies and NOT supplied via the version information. This is probably fine, but it feels a bit un-intuitive.