mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[Issue]: nvenc slow/slower preset order #4733
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheTyrius on GitHub (Mar 25, 2023).
Please describe your bug
While browsing the transcoding code I noticed that for nvenc the "slow" setting uses a higher preset than the "slower" one. This seemed unintuitive to me, shouldn't it be the other way around? See
9f7418cf42/MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (L1554-L1564)-> slow uses p6, slower p5, but veryslow is p7
Jellyfin Version
10.8.0
if other:
No response
Environment
Jellyfin logs
No response
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@nyanmisaka commented on GitHub (Mar 25, 2023):
It seems the
slowandslowercases are inverted. Feel free to open a PR to fix it.@TheTyrius commented on GitHub (Mar 25, 2023):
Closed by https://github.com/jellyfin/jellyfin/pull/9538