mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Collections: Store reliable total duration #3775
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doc-code-hub on GitHub (Apr 26, 2022).
Introduction
Viewing the total duration of a content on the detail page can be very useful as information, for organizing or predicting the end.
Likewise, I think it could be convenient and useful to be able to view the total duration of a collection (eg to plan a marathon).
Image from my PR
Suggested Enancement
Basically I would like the total RunTimeTicks of the collection to be saved, recursively obtained from all the children.
This way clients would be able to show them immediately in user-readable format.
I had tried to achieve this purpose client-side ( on jellyfin-web #3552 ), however it remains impossible to have a reliable total duration with all types of content ( e.g. with collection inside collection), moreover the information was deduced by the children, who were retrieved at a later time, introducing a delay.
It has been pointed out to me (by @thornbill), and I agree, that it would be much better if this information were computed and stored server-side.
In this regard, I am trying to propose an implementation on the related PR and i'm open to suggestions (on the PR please :) )
My Implementation in short
@jellyfin-bot commented on GitHub (Aug 24, 2022):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
@thornbill commented on GitHub (Aug 24, 2022):
Still relevant 🙂
@jellyfin-bot commented on GitHub (Mar 22, 2023):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.