mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[Issue]: Search does not work properly for åäö #3684
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LinAGKar on GitHub (Mar 21, 2022).
Please describe your bug
Searching for a word containing å, ä or ö does not work properly, as Jellyfin replaces it with the similar-looking ASCII character. So for example, if you type "Jön", "Indiana Jones" will be included in the results, but not "Jönssonligan".
Jellyfin Version
Other
if other:
10.8-alpha5
Environment
Jellyfin logs
No response
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@cbenco commented on GitHub (Mar 27, 2022):
Seems like the Diacritics package doesn't strip this diaeresis correctly out of the film name retrieved from TMDB
@Jellifi007 commented on GitHub (Apr 14, 2022):
This bug is related to regression introduced by Bond-009@981cf4cfa0d45a3654578a1989738fc82469c889
Reverting to our own RemoveDiacritics extension should do the work (not sure why this has been changed).
I think we should put our own "reverted RemoveDiacritics extension" in
a separated project ("Jellyfin.Diacritics" ?) to allow for less coupling with existing projects, rather than re-adding the extension into "MediaBrowser.Controller.Extensions;" like beforeJellyfin.Extensions.StringExtensions.Proposed target class optimized with shared thread safe regex object :

Proposed source :
Extensions.cs.zip
Diacritics package has to be removed and import references corrected in following projects in order to restore correct Jellyfin behavior:

if someone can approve the strategy I will do the PR.