mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
Empty subtitle file returned when getting external #304
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Tthecreator on GitHub (Jan 21, 2019).
Intro
I've setup jellyfin in VS for myself and have been fiddling around a little bit with subtitles. My idea was for myself to add .ass support for the web interface trough a js library. During that process I found that external subtitle files were not even correctly given to the client in the first place.
To Reproduce
Steps to reproduce the behavior:
I've been using this as a testfile: https://github.com/brenopolanski/html5-video-webvtt-example
I've also renamed the subtitle files to MIB2.vtt. I'm mainly testing the .vtt subtitles for now to see how things work.
I tried the following request: http://localhost:8096/emby/Videos/79f83831-1e56-692a-66e3-f978776a9bb4/79f838311e56692a66e3f978776a9bb4/Subtitles/3/0/Stream.vtt?api_key=cb7c618d09a949999de9ca8e53f50dcf (I got this request from wireshark)
See error
Bug
This should return at least some subtitle data. Instead only 'WEBVTT' is returned with nothing else. My subtitle file is indeed filled.
System (please complete the following information):
Additional context
I'm currently trying to solve this problem myself but am still reporting it as I'm quite overwhelmed with the amount of code that this project has. I've been mazing my way trough all the subtitle code and am figuring it out step by step. Though if I do give up eventually I will have still made the report.
@JustAMan commented on GitHub (Jan 21, 2019):
Might be related to https://github.com/jellyfin/jellyfin/pull/636
@Tthecreator commented on GitHub (Jan 21, 2019):
Manually applying the change from #636 doesn't seem to affect my problem.
@Tthecreator commented on GitHub (Jan 21, 2019):
I'm currently working on this after solving the last bug, and there seem to be some problems, but I could see this issue 'evolve' way too much so I'm going to wait with posting anything until I figure out what my exact problem is.
@cvium commented on GitHub (Jan 21, 2019):
It's fixed in #629 ;)
@Tthecreator commented on GitHub (Jan 21, 2019):
Wow yes it actually was. I was looking at the wrong place. I thought it has something to do with GetReadableFile(). It forced the use of subtitle conversion to .srt when there wasn't a parser for the original subtitle format, even if that parser wasn't even needed at all. But this seems to fix the issue some other place so thanks!
@Tthecreator commented on GitHub (Jan 21, 2019):
Okay great now internal subtitles aren't working again. Not detected... weird