mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Show improved version information to users #285
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joshuaboniface on GitHub (Jan 16, 2019).
A spin-off discussion from #508 and #509.
Let's discuss our opinions and philosophical arguments for various forms of improved user versioning information.
@joshuaboniface commented on GitHub (Jan 17, 2019):
What I'd like to see
jellyfin-webrepo as well.Why?
@EraYaN commented on GitHub (Jan 17, 2019):
I can modify the #508 to contain those pieces of info. But that won't reduce it's complexity in anyway. You will still need a script, a file and something to parse it. We can debate for a long time about what the least complex file format is, but frankly it really doesn't matter. For all I care it's fucking json if that makes anyone happy.
Long story short, we will end up if we want the above points at the same level of complexity regardless. All the other points are implementation details, and are frankly a lot more inconsequential.
@ploughpuff commented on GitHub (Jan 17, 2019):
@joshuaboniface I have put together a 'help' page for devs when running from command line:
61eb8a9e3cWorth pursuing with?
@JustAMan commented on GitHub (Jan 17, 2019):
Great find by @anthonylavado: https://github.com/AArnott/Nerdbank.GitVersioning
@joshuaboniface commented on GitHub (Jan 17, 2019):
@EraYaN @nvllsvm @Bond-009 This GitVersioning thing looks to be literally exactly what we want. Is it feasible to use?
@EraYaN commented on GitHub (Jan 17, 2019):
Well it will only stamp the current git version of one repo, AND it will not use a three part semver but only a 2 part semver. If you can live with that concession, I guess yes.
It also needs the .git folder during build at all times.