mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Able to go negative page numbering #238
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @agilob on GitHub (Jan 8, 2019).
This is probably inherited from Emby and linked to a race condition on request-> response level.
Seems like the "previous page" button is only disabled when lower boundary is 0:
@cvium commented on GitHub (Jan 8, 2019):
I would like to add that it's a general problem. I accidentally added the same library twice because of a slow response.
@hawken93 commented on GitHub (Jan 11, 2019):
Looking at the pagination code I want to note that splitting the paginator code from the individual libraries so it can share common logic is a possible improvement
@hawken93 commented on GitHub (Jan 11, 2019):
I think what you are getting at here is that the pagination buttons should not trigger more events until the next page is loaded, and for the library I didn't really look at it, but I guess it's about waiting until the server is done as well?
For this issue it's possible to just limit the page number to 0, either by not decrementing the number past 0, or bringing it up to 0 again before processing the request. The variable that holds this information seems to stay within each of the different places in the javascript that pagination is implemented. Each one is slightly different :P But maybe deactivating the event handler while the request is processing is the better fix.
@hawken93 commented on GitHub (Jan 11, 2019):
performance optimalization possibilityThe javascript calls ApiClient.GetItems() before filtering them to the current page. This means that each pagination actually downloads information about all the items in the library before filtering them on the client side. This wastes lots of resources and should be done on the server side.
query is passed to the getItems request, so I'm wrong here
@JustAMan commented on GitHub (Jan 12, 2019):
This seems to be the most fruitful approach, usually the less almost copy-paste is there the easier it is to maintain stuff.
@hawken93 commented on GitHub (Jan 12, 2019):
to quote myself: I don't think I'll be trying to unify the pagination code in this PR, but if someone wants do that that then please merge them before this
@hawken93 commented on GitHub (Jan 13, 2019):
I'm ready for review on the PR above now :)
@hawken93 commented on GitHub (Jan 13, 2019):
@cvium I've also fixed the library double adding thing, so now it shows the loading indicator and ignores multiple presses until the action has returned a result :)