mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Investigate purpose of displaypreferences.db #213
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sparky8251 on GitHub (Jan 6, 2019).
This is part of #42 and #422.
This one is as screwed as
users.db. It has an index joining 3 of the 4 fields in the sole table. And one of the 4 fields is another JSON blob.The 4 table fields are (note the lack of a master key):
idwhich isGUIDuserIdwhich isGUIDclientwhich isTEXTdatawhich isBLOBThe prettyfied JSON blob looks like:
Of these fields the following questions come to mind:
idWhy does this value not equal any other id values in any other DB? Why is it later repeated in the blob where it then matches some id strings in other DBs? At the very least, this should be turned into the master key since this DB lacks one.userIdWhy does this value not equal any other id value in any other DB? Can it be removed?clientThis just stores "emby" as a string. Why is this needed? Can it be removed?RememberIndexingWhat is this and why is it false by default? Can it be removed?PrimaryImageHeightIs this what the image type in theusers.dbwas for? Can it be removed?PrimaryImageWithIs this what the image type in theusers.dbwas for? Can it be removed?CustomPrefsWhy does this contain its own nested JSON structures? Can it be removed?dashboardThemeWhy is this a blank string? Can it be removed?<server-ip-address>/web/index.htmlseriesWhy does this even exist? Can it be removed?SortByis set toSortNamefor me. Is this even user configurable? Can it be removed?SortOrderis set toAscendingfor me. Is this even user configurable? Can it be removed?ScrollDirectionis set toHorizontalfor me. Is this even user configurable? Can it be removed?ShowBackdropis set to true for me. What does this do? Can it be removed?RememberSortingis set to false for me. Is this even user configurable? Can it be removed?SortOrderis set toAscendingfor me. Why is this duplicated from the above nested JSON? Can it be removed?ShowSidebaris set to false. Is this even user configurable? Can it be removed?Clientis set to "emby" just like the table. Why does this exist? Can it be removed?As we track down where and why these things exist, we should look at creating a
userdisplaypreferencesv2table format that doesn't rely on a single large blob. Will make future migrations to new formats much easier. When this eventually leads to a new table format, we should make ajellyfin.dbfile to store the new table and eventually roll the other dbs into it.@stale[bot] commented on GitHub (Jul 30, 2019):
Issues go stale after 60d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 7d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.