mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-25 06:03:37 +03:00
Restart btn on dashboard is missing #209
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @grafixeyehero on GitHub (Jan 6, 2019).
Originally assigned to: @anthonylavado on GitHub.
Restart btn on dashboard is missing only show sutdown btn
platform windows
@anthonylavado commented on GitHub (Jan 7, 2019):
I think this is because we can't automatically restart the service on Windows like we can on Linux. This is because we're not a nicely packaged .exe just yet. I could be wrong.
@LogicalPhallacy thoughts?
@Bond-009 commented on GitHub (Jan 13, 2019):
Pretty sure you need to specify a restart script for it to work.
@sparky8251 commented on GitHub (Feb 7, 2019):
What's going on with this? Is it not a duplicate of https://github.com/jellyfin/jellyfin-web/issues/108?
@LogicalPhallacy commented on GitHub (Feb 14, 2019):
This is a bit complicated. It should probably be tagged with the dot net core 3 tag because that can fix this (whatever turns the button off would also need addressing). Basically without a real service framework (i.e. not NSSM) we can't cleanly stop and restart the exe. Once the dot net core 3 winforms stuff is there, we've got an issue to restore minimize to tray and possibly add native windows service integration (depends on how a few things shake out). With those in place we can then get the restart button back on windows.
@JustAMan commented on GitHub (Feb 14, 2019):
Transferred back to server, as we apparently need server support for that button to become available.
@bengalih commented on GitHub (Sep 9, 2019):
Going to add to this rather than start a new bug.
In addition to no restart button, the shutdown option also doesn't work when running as a service (via nssm).
While I don't know the innards of JF from Adam, I can say that there are other services I use which run via NSSM and support shutdown and restart. CouchPotato is one of these.
Pretty sure that's in Python, which may be apples and oranges here.
I don't know what is planned for the future, but it would appear there could be someway to add a reinitialization/shutdown procedure into the executable.
@leonelsr commented on GitHub (Jan 3, 2020):
I'd like to add that Emby on Windows still does have the restart feature from the web interface. How far are we from their codebase?
There are other bugs that existed before and have been already fixed on Emby, but are still present on Jellyfin. Such as the DLNA server not being detected when port 1900 is already in use (#1322 I guess)
@anthonylavado commented on GitHub (Jan 5, 2020):
@leonelsr Emby hasn’t had a public commit since September 2018, and we also had to revert specific sections back as far as May 2018. There’s nothing further we can import from their code for the server, we are completely on our own here. Since we’ve also changed core runtimes and many other things to start, it’s not as easy as trying to find the same old line or two and adding it in.
That said, I’ll see what I can do for a future release.
@dkanada commented on GitHub (Jan 22, 2020):
This isn't an interface issue, the windows build just needs an argument with the location of a script that will restart the server. This can apparently be done within the code on newer DotNet versions as well.
@stale[bot] commented on GitHub (May 21, 2020):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
@bengalih commented on GitHub (May 21, 2020):
Is there any movement on this? From the comments it sounds like this was not seen as an issue due to some script that can be used? I'm unsure why this doesn't seem like a requirement, out of (at least) 8 media centered web-based services I run on my system, JF is the only one that doesn't provide an inbuilt update function or restart option. I'm mentioning this here (although I should probably file another bug/request) that the omission of an auto-update feature is definitely contributing to extra work for both the dev team and user community since people continue to work with older versions and can't stay in sync over how functions are implemented and supported. I see there is an update notification in the dashboard, but never once have I actually been sent any type of notification on new release.
@dkanada commented on GitHub (May 22, 2020):
Out of curiosity, what are the eight services that include a restart button?
@bengalih commented on GitHub (May 22, 2020):
Sonarr, Radarr, Jackett, CouchPotato, Sabnzbd, Tautulli, Organizr, Headphones
@stale[bot] commented on GitHub (Sep 19, 2020):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
@joshuaboniface commented on GitHub (Nov 23, 2020):
To sort of explain this one.
The
Restartbutton is only shown/enabled if the--restartpathargument is passed to the binary. On Windows this isn't done in our packaging, which is why the button isn't there. This is indeed a holdover from how Emby did it (with the hacky restart script).The
Shutdownbutton just terminates the program, however I'm guessing that with the NSSM Windows service, it's auto-restarting because it thinks it should always be up. So that's a bit of a hack to getRestartfunctionality, but it would work. It won't really help in terms of actually stopping Jellyfin though.We could try writing a Windows script to restart the service, which will allow this to work, but this is an external setup. We should definitely look at how the other C#-based Arr tools do this however.
@cvium commented on GitHub (Apr 9, 2021):
Working as intended even if it's kind of bad...