SDDP devices fire DeviceFound event even if the device is already know. #2008

New Issue

OVERLORD · 2026-02-06T21:37:16+03:00

OVERLORD commented

2026-02-06 21:37:16 +03:00

Originally created by @BaronGreenback on GitHub (Aug 4, 2020).

Logging this as a placeholder - whilst i fully test the implications.

Seen this multiple time - the same device is processed numerous times as the following function assumes even a repeat device is new.

private bool AddOrUpdateDiscoveredDevice(DiscoveredSsdpDevice device, IPAddress localIpAddress)
        {
            bool isNewDevice = false;
            lock (_devices)
            {
                var existingDevice = FindExistingDeviceNotification(_devices, device.NotificationType, device.Usn);
                if (existingDevice == null)
                {
                    _devices.Add(device);
                    isNewDevice = true;
                }
                else
                {
                    _devices.Remove(existingDevice);
                    _devices.Add(device);
                }
            }

            DeviceFound(device, isNewDevice, localIpAddress);

            return isNewDevice;
        }

Fix is wrap DeviceFound with

            if (isNewDevice)
            {
                 DeviceFound(device, isNewDevice, localIpAddress);
            }

Originally created by @BaronGreenback on GitHub (Aug 4, 2020). Logging this as a placeholder - whilst i fully test the implications. Seen this multiple time - the same device is processed numerous times as the following function assumes even a repeat device is new. ``` private bool AddOrUpdateDiscoveredDevice(DiscoveredSsdpDevice device, IPAddress localIpAddress) { bool isNewDevice = false; lock (_devices) { var existingDevice = FindExistingDeviceNotification(_devices, device.NotificationType, device.Usn); if (existingDevice == null) { _devices.Add(device); isNewDevice = true; } else { _devices.Remove(existingDevice); _devices.Add(device); } } DeviceFound(device, isNewDevice, localIpAddress); return isNewDevice; } ``` Fix is wrap DeviceFound with ``` if (isNewDevice) { DeviceFound(device, isNewDevice, localIpAddress); } ```

OVERLORD added the bug label 2026-02-06 21:37:16 +03:00

OVERLORD closed this issue

2026-02-06 21:37:18 +03:00

OVERLORD referenced this issue

2026-02-07 05:53:49 +03:00

[PR #2008] [MERGED] Fix GetPathValue function #8973

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#2008