mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Unreasonable systemd unit dependency setting #1735
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MintMana on GitHub (May 26, 2020).
Originally assigned to: @joshuaboniface on GitHub.
Describe the bug
After=network.target is a wrong setting for applications which requires network.
System (please complete the following information):
system independent bug
To Reproduce
The unreasonable setting might be harmless although it should be fixed.
Additional context
According to the document of systemd, network-online.target means that the network is configured and applications which need network is ready to be started.
https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Many other applications including nginx have fixed this bug recently. This problem actually exists in tons of applications if taking a look at RH bugzillia.
https://github.com/nginxinc/nginx-wiki/pull/507
https://github.com/openresty/openresty/issues/590
https://bugzilla.redhat.com/show_bug.cgi?id=1119787
Please evaluate if other dependency is needed for jellyfin.
syslog.target network-online.target remote-fs.target nss-lookup.target
@stale[bot] commented on GitHub (Sep 26, 2020):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
@MintMana commented on GitHub (Sep 26, 2020):
not fixed yet
@stale[bot] commented on GitHub (Jan 24, 2021):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.
@joshuaboniface commented on GitHub (Jan 25, 2021):
All reasonable suggestions.
network-online.targetis definitely better, andremote-fs.targetwould be good too. A PR would be welcome; if not, I'll fix this up soon.