mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
Replace API keys/Investigate Metadata Services #17
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anthonylavado on GitHub (Dec 11, 2018).
Originally assigned to: @anthonylavado, @joshuaboniface on GitHub.
In a few different areas, there are API keys for TheMovieDB and The TVDB. We should probably remove these.
Since there doesn't appear to be any better alternative metadata providers, I feel we should continue using these, and we can get API keys of our own for the project.
There are a few concerns however:
TheMovieDB allows use in non-commercial projects without cost, but there is a rate limit (see FAQ)
TheMovieDB is created by user contributions, but there are terms to agree to in order to use the data (see API - Terms of Use)
The TVDB does have data available with less onerous terms (all I could find was the line at the bottom of their website)
The TVDB doesn't appear to rate-limit, or if they do, it's not obviously mentioned (see API)
We can avoid hits on the TMDB API by following a similar approach to Firecore for their Infuse program. See: https://firecore.com/forum/topic/18385
Another option is to go all out and not include API keys, but make this user configurable somehow. That might be a future goal however, and I don't know if anything in the terms of either provider discourages/prohibits that type of use.
@joshuaboniface commented on GitHub (Dec 11, 2018):
I'd rather us sign up for a single one, maybe explain the situation and work out a deal with them. Having to roll your own was sonething I hated about Streama.
@JustAMan commented on GitHub (Dec 11, 2018):
There's even easier approach, much like streama does - make an empty field so the user fill their token inside, and not ship a built-in Jellyfin token at all.
That said, I'm not objecting to contacting TMDB and TVDB about special key... but don't have time now to do so, would anyone step up to it?
@anthonylavado commented on GitHub (Dec 12, 2018):
That's what I meant to begin with really.
We should try to reach out to them at some point soon. Hopefully something can be worked out. I would think the order here is:
That way, even if we can't broker a deal with them, someone can still put in their own user keys, which would then not add to one key making a huge number of requests.
@anthonylavado commented on GitHub (Dec 13, 2018):
Linking this for review as well:
21a8d27378/MediaBrowser.Providers/Music/MusicBrainzAlbumProvider.cs (L815)Looks like MB is just rate-limited in code. Must investigate how to better integrate.
@anthonylavado commented on GitHub (Dec 13, 2018):
From discussion in Riot/Matrix:
@joshuaboniface commented on GitHub (Dec 13, 2018):
I've contacted The Movie DB to discuss. I've also signed up for MusicBrainz at @LeoVerto 's mention as a non-profit organization. Awaiting replies there. Still need to find contacts for The TV DB.
@joshuaboniface commented on GitHub (Dec 13, 2018):
Found and contacted TheTVDB as well.
@anthonylavado commented on GitHub (Dec 17, 2018):
Just to provide an update - on last check (Saturday night), we haven't received any communication back yet.
@BobOkisama commented on GitHub (Dec 17, 2018):
Oddly, everything is now working for me. I had to manually go and re-identify each movie, but once done it was able to connect, get all art, and even can search additional art now.
@JustAMan commented on GitHub (Dec 17, 2018):
Might be an issue with hardcoded API key. We'll know better when we move to our own keys.
@anthonylavado commented on GitHub (Jan 4, 2019):
For OpenSubtitles, there is a small manual process. I'll get this started: http://trac.opensubtitles.org/projects/opensubtitles/wiki/DevReadFirst
@joshuaboniface commented on GitHub (Jan 9, 2019):
I've never heard back from any of the API services. I strongly dislike forcing the user to use their own API keys (this was, honestly, my #1 reason for not using Streama, because I personally don't agree to their [edit: The Movie DB's] ToS, though on a project level I would). I'm not sure how best to proceed here.
@anthonylavado commented on GitHub (Jan 9, 2019):
@JoshuaBoniface - We proceed as normal getting regular API keys for these services as best as possible. If it breaks, it breaks. If you did try contacting them all, the we have the receipt to prove we tried.
@joshuaboniface commented on GitHub (Jan 10, 2019):
I've obtained API keys for:
Integrated in PR #540
@anthonylavado commented on GitHub (Jan 11, 2019):
Okay, this satisfies this Issue for me. We can come back to adding user supplied keys at a later time.