starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #16178] [MERGED] Skip validation for empty landing preferences #14552

New Issue
Closed
opened 2026-02-07 07:31:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:31:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/16178
Author: @theguymadmax
Created: 2/3/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @Bond-009

Base: master ← Head: fix-invaild-viewtype

📝 Commits (1)

  • 613d72f Skip empty ViewType validation

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 Jellyfin.Api/Controllers/DisplayPreferencesController.cs (+10 -2)

📄 Description

Changes

The WebUI sends empty strings for default landing screens, which were incorrectly being validated and logged as errors. Empty or null strings will now be skipped.

Issues

[2026-02-03 05:43:40.703 +00:00] [ERR] [62] Jellyfin.Api.Controllers.DisplayPreferencesController: Invalid ViewType: ""

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/16178 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 2/3/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-invaild-viewtype` --- ### 📝 Commits (1) - [`613d72f`](https://github.com/jellyfin/jellyfin/commit/613d72fa26375b29b6c5da7933feff8ace1ac54e) Skip empty ViewType validation ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/DisplayPreferencesController.cs` (+10 -2) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> The WebUI sends empty strings for default landing screens, which were incorrectly being validated and logged as errors. Empty or null strings will now be skipped. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> `[2026-02-03 05:43:40.703 +00:00] [ERR] [62] Jellyfin.Api.Controllers.DisplayPreferencesController: Invalid ViewType: ""` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:31:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?