starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #16160] Fix ItemValues Type checks #14543

New Issue
Open
opened 2026-02-07 07:31:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:31:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/16160
Author: @Shadowghost
Created: 2/1/2026
Status: 🔄 Open

Base: master ← Head: fix-itemvalues-uniqueness

📝 Commits (2)

  • 77ff451 Only save unique values of ProductionLocations, Studios, Tags, Artists and AlbumArtists
  • 1dacb69 Fix Genre Uniqueness

📊 Changes

2 files changed (+20 additions, -19 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ItemUpdateController.cs (+6 -6)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+14 -13)

📄 Description

Changes

  • Line 1299 uses e.Type + "+" which converts the enum to its name (e.g., "Studios"), while line 1301 uses (int)e.MagicNumber which produces the integer value (e.g., "3") which makes the comparison fail.

Issues
Fixes #16156
Fixes #16157

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/16160 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 2/1/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-itemvalues-uniqueness` --- ### 📝 Commits (2) - [`77ff451`](https://github.com/jellyfin/jellyfin/commit/77ff451e60fa1fee31da1f5987e6e47a22244bb8) Only save unique values of ProductionLocations, Studios, Tags, Artists and AlbumArtists - [`1dacb69`](https://github.com/jellyfin/jellyfin/commit/1dacb69d80d0fd65f8c45dd54ab278bc8fb28ed1) Fix Genre Uniqueness ### 📊 Changes **2 files changed** (+20 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ItemUpdateController.cs` (+6 -6) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+14 -13) </details> ### 📄 Description **Changes** * Line 1299 uses `e.Type + "+"` which converts the enum to its name (e.g., "Studios"), while line 1301 uses `(int)e.MagicNumber` which produces the integer value (e.g., "3") which makes the comparison fail. **Issues** Fixes #16156 Fixes #16157 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:31:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14543
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?