starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-15 21:37:59 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #16124] [MERGED] Fix: Resolve CA1849 synchronous IO in EpubImageProvider #14532

New Issue
Closed
opened 2026-02-07 07:31:21 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:31:21 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/16124
Author: @Gladtbam
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @crobibero

Base: master ← Head: fix/epub-async-io

📝 Commits (1)

  • c762f06 fix: Resolve CA1849/CA2007 synchronous IO in EpubImageProvider

📊 Changes

1 file changed (+10 additions, -8 deletions)

View changed files

📝 MediaBrowser.Providers/Books/OpenPackagingFormat/EpubImageProvider.cs (+10 -8)

📄 Description

Fixes build errors related to CA1849 in .NET 10.0 builds.

Changes

  • Replaced synchronous ZipFile.OpenRead with ZipFile.OpenReadAsync.

  • Replaced synchronous ZipArchiveEntry.Open with ZipArchiveEntry.OpenAsync.

  • Implemented await using for IAsyncDisposable resources (Streams and ZipArchive) to prevent leaks.

  • Added ConfigureAwait(false) to async disposables to avoid capturing the sync context.

Issues

none

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/16124 **Author:** [@Gladtbam](https://github.com/Gladtbam) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix/epub-async-io` --- ### 📝 Commits (1) - [`c762f06`](https://github.com/jellyfin/jellyfin/commit/c762f0681eed847c5947ac2ec57c8212d0414d78) fix: Resolve CA1849/CA2007 synchronous IO in EpubImageProvider ### 📊 Changes **1 file changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Books/OpenPackagingFormat/EpubImageProvider.cs` (+10 -8) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> Fixes build errors related to CA1849 in .NET 10.0 builds. **Changes** <!-- Describe your changes here in 1-5 sentences. --> - Replaced synchronous ZipFile.OpenRead with ZipFile.OpenReadAsync. - Replaced synchronous ZipArchiveEntry.Open with ZipArchiveEntry.OpenAsync. - Implemented await using for IAsyncDisposable resources (Streams and ZipArchive) to prevent leaks. - Added ConfigureAwait(false) to async disposables to avoid capturing the sync context. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> none --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:31:21 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?