starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-15 21:37:59 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #16106] [CLOSED] Fix TMDB image URLs missing size parameter #14524

New Issue
Closed
opened 2026-02-07 07:31:11 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:31:11 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/16106
Author: @saltpi
Created: 1/25/2026
Status: ❌ Closed

Base: release-10.11.z ← Head: master

📝 Commits (10+)

  • 28b0657 Backport pull request #15217 from jellyfin/release-10.11.z
  • 21f65e2 Backport pull request #15220 from jellyfin/release-10.11.z
  • 7d778d7 Translated using Weblate (Alemannic)
  • f92eca3 Translated using Weblate (Mongolian)
  • f21fe9f Translated using Weblate (Chinese (Traditional Han script, Hong Kong))
  • 573ce9c Translated using Weblate (Mongolian)
  • 83d0dbd Update github/codeql-action action to v4.31.2
  • 23929a3 Translated using Weblate (Chinese (Traditional Han script, Hong Kong))
  • ffe82be Translated using Weblate (Chinese (Traditional Han script, Hong Kong))
  • 63f06aa Update dependency Serilog.Sinks.Console to 6.1.1

📊 Changes

269 files changed (+3734 additions, -2206 deletions)

View changed files

📝 .config/dotnet-tools.json (+1 -1)
📝 .editorconfig (+7 -0)
📝 .github/CODEOWNERS (+11 -4)
📝 .github/ISSUE_TEMPLATE/issue report.yml (+13 -5)
📝 .github/workflows/ci-codeql-analysis.yml (+9 -6)
📝 .github/workflows/ci-compat.yml (+11 -11)
📝 .github/workflows/ci-openapi.yml (+33 -74)
📝 .github/workflows/ci-tests.yml (+4 -4)
📝 .github/workflows/commands.yml (+6 -3)
📝 .github/workflows/issue-stale.yml (+1 -1)
📝 .github/workflows/issue-template-check.yml (+5 -2)
📝 .github/workflows/project-automation.yml (+1 -0)
📝 .github/workflows/pull-request-stale.yaml (+1 -1)
📝 .github/workflows/release-bump-version.yaml (+2 -2)
📝 .vscode/launch.json (+3 -3)
📝 CONTRIBUTORS.md (+6 -0)
📝 Directory.Packages.props (+37 -46)
➕ Emby.Naming/Book/BookFileNameParser.cs (+75 -0)
➕ Emby.Naming/Book/BookFileNameParserResult.cs (+41 -0)
📝 Emby.Naming/Emby.Naming.csproj (+2 -2)

...and 80 more files

📄 Description

Changes

When TMDB plugin configuration size values (PosterSize, BackdropSize, etc.)
are null or empty, the GetUrl() method now defaults to "original" instead of
passing null/empty to the TMDb client. This prevents malformed URLs like
"https://image.tmdb.org/t/p//filename.jpg" and ensures proper format
"https://image.tmdb.org/t/p/original/filename.jpg".

Fixes remote image search failing to display TMDB images in Edit Images modal.

Issues

Fix TMDB image URLs missing size parameter #16102

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/16106 **Author:** [@saltpi](https://github.com/saltpi) **Created:** 1/25/2026 **Status:** ❌ Closed **Base:** `release-10.11.z` ← **Head:** `master` --- ### 📝 Commits (10+) - [`28b0657`](https://github.com/jellyfin/jellyfin/commit/28b0657608e144dead4100e6b3d89ccea763a5cf) Backport pull request #15217 from jellyfin/release-10.11.z - [`21f65e2`](https://github.com/jellyfin/jellyfin/commit/21f65e2e27720b43ac7d42ccf645c69c3d619bc1) Backport pull request #15220 from jellyfin/release-10.11.z - [`7d778d7`](https://github.com/jellyfin/jellyfin/commit/7d778d7befd271f08d202494c92bc9c3666c18ec) Translated using Weblate (Alemannic) - [`f92eca3`](https://github.com/jellyfin/jellyfin/commit/f92eca3efb2b01b5c5b4ab862ede2620bdf214c9) Translated using Weblate (Mongolian) - [`f21fe9f`](https://github.com/jellyfin/jellyfin/commit/f21fe9f95ea8f8b0da5f7ce315feab4c0b4925dd) Translated using Weblate (Chinese (Traditional Han script, Hong Kong)) - [`573ce9c`](https://github.com/jellyfin/jellyfin/commit/573ce9ceaac41d35b9e9431457e66ce06bf17e77) Translated using Weblate (Mongolian) - [`83d0dbd`](https://github.com/jellyfin/jellyfin/commit/83d0dbdbcbe02382863dd48ad15b88ad2f48cb89) Update github/codeql-action action to v4.31.2 - [`23929a3`](https://github.com/jellyfin/jellyfin/commit/23929a3e709f4324d49271c02b0b047e1149e860) Translated using Weblate (Chinese (Traditional Han script, Hong Kong)) - [`ffe82be`](https://github.com/jellyfin/jellyfin/commit/ffe82be7a7a2ea6ab6d0e543f58ecd01df4085ef) Translated using Weblate (Chinese (Traditional Han script, Hong Kong)) - [`63f06aa`](https://github.com/jellyfin/jellyfin/commit/63f06aad9420b31a1cc79052b0408fb8c96e1c72) Update dependency Serilog.Sinks.Console to 6.1.1 ### 📊 Changes **269 files changed** (+3734 additions, -2206 deletions) <details> <summary>View changed files</summary> 📝 `.config/dotnet-tools.json` (+1 -1) 📝 `.editorconfig` (+7 -0) 📝 `.github/CODEOWNERS` (+11 -4) 📝 `.github/ISSUE_TEMPLATE/issue report.yml` (+13 -5) 📝 `.github/workflows/ci-codeql-analysis.yml` (+9 -6) 📝 `.github/workflows/ci-compat.yml` (+11 -11) 📝 `.github/workflows/ci-openapi.yml` (+33 -74) 📝 `.github/workflows/ci-tests.yml` (+4 -4) 📝 `.github/workflows/commands.yml` (+6 -3) 📝 `.github/workflows/issue-stale.yml` (+1 -1) 📝 `.github/workflows/issue-template-check.yml` (+5 -2) 📝 `.github/workflows/project-automation.yml` (+1 -0) 📝 `.github/workflows/pull-request-stale.yaml` (+1 -1) 📝 `.github/workflows/release-bump-version.yaml` (+2 -2) 📝 `.vscode/launch.json` (+3 -3) 📝 `CONTRIBUTORS.md` (+6 -0) 📝 `Directory.Packages.props` (+37 -46) ➕ `Emby.Naming/Book/BookFileNameParser.cs` (+75 -0) ➕ `Emby.Naming/Book/BookFileNameParserResult.cs` (+41 -0) 📝 `Emby.Naming/Emby.Naming.csproj` (+2 -2) _...and 80 more files_ </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> When TMDB plugin configuration size values (PosterSize, BackdropSize, etc.) are null or empty, the GetUrl() method now defaults to "original" instead of passing null/empty to the TMDb client. This prevents malformed URLs like "https://image.tmdb.org/t/p//filename.jpg" and ensures proper format "https://image.tmdb.org/t/p/original/filename.jpg". Fixes remote image search failing to display TMDB images in Edit Images modal. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fix TMDB image URLs missing size parameter #16102 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:31:11 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?