[PR #16033] [10.11] Fix querying media with language filters #14501

Open
opened 2026-02-07 07:30:50 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/16033
Author: @MBR-0001
Created: 1/15/2026
Status: 🔄 Open

Base: release-10.11.zHead: release-10.11.z


📝 Commits (1)

  • e87fe6c Fix querying media with language filters

📊 Changes

1 file changed (+34 additions, -9 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+34 -9)

📄 Description

After looking into subtitle handing in jellyfin I've realized the situation is not great, some tables hold the language in one format, code queries it in another and all sorts of issues come up.

Changes
For all queries that include languages: localizationManager is used to get all (both?) language name variants for the wanted language.
Example: query is for german (deu) so via localizationManager we get both deu and ger, and then check for both of those in the query. (From my understanding of EF Language = 'deu' -> Language IN ('deu', 'ger') .

Any input is welcome, I hope this fixes the listed issues and doesn't break anything :)

Issues
Maybe (hopefully)
fixes #9606
fixes #15513
fixes #12434
fixes https://github.com/jellyfin/jellyfin-plugin-opensubtitles/issues/185


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/16033 **Author:** [@MBR-0001](https://github.com/MBR-0001) **Created:** 1/15/2026 **Status:** 🔄 Open **Base:** `release-10.11.z` ← **Head:** `release-10.11.z` --- ### 📝 Commits (1) - [`e87fe6c`](https://github.com/jellyfin/jellyfin/commit/e87fe6cef165bc6883c021cbb237c5526bd929da) Fix querying media with language filters ### 📊 Changes **1 file changed** (+34 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+34 -9) </details> ### 📄 Description After looking into subtitle handing in jellyfin I've realized the situation is not great, some tables hold the language in one format, code queries it in another and all sorts of issues come up. **Changes** For all queries that include languages: localizationManager is used to get all (both?) language name variants for the wanted language. Example: query is for german (_deu_) so via localizationManager we get both _deu_ and _ger_, and then check for both of those in the query. (From my understanding of EF `Language = 'deu'` -> `Language IN ('deu', 'ger')` . Any input is welcome, I hope this fixes the listed issues and doesn't break anything :) **Issues** _Maybe (hopefully)_ fixes #9606 fixes #15513 fixes #12434 fixes https://github.com/jellyfin/jellyfin-plugin-opensubtitles/issues/185 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:30:50 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14501