starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #15924] [MERGED] Fixed issue with ABI Compatability - Difference not completing #14462

New Issue
Closed
opened 2026-02-07 07:30:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:30:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15924
Author: @PeachesMLG
Created: 1/1/2026
Status: ✅ Merged
Merged: 1/2/2026
Merged by: @crobibero

Base: master ← Head: fix_api_compat

📝 Commits (1)

  • a1231cb Fixed issue with ABI Compatability - Difference not completing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .github/workflows/ci-compat.yml (+1 -1)

📄 Description

Changes
When there are differences in the api file, we return exit code 1 and terminate the execution which results in an invalid file being generated and no EOF deliminater.

This simply adds a || true to prevent it exiting early

Fixes issues found in other PR's e.g.:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15924 **Author:** [@PeachesMLG](https://github.com/PeachesMLG) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 1/2/2026 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix_api_compat` --- ### 📝 Commits (1) - [`a1231cb`](https://github.com/jellyfin/jellyfin/commit/a1231cb6c301bad93c2b836d9bb826986119242f) Fixed issue with ABI Compatability - Difference not completing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci-compat.yml` (+1 -1) </details> ### 📄 Description **Changes** When there are differences in the api file, we return exit code 1 and terminate the execution which results in an invalid file being generated and no EOF deliminater. This simply adds a `|| true` to prevent it exiting early Fixes issues found in other PR's e.g.: * https://github.com/jellyfin/jellyfin/pull/15921 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:30:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14462
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?