[PR #15872] [MERGED] Be more strict about PersonType assignment #14445

New Issue

OVERLORD · 2026-02-07T07:29:55+03:00

OVERLORD commented

2026-02-07 07:29:55 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15872
Author: @Shadowghost
Created: 12/27/2025
Status: ✅ Merged
Merged: 1/17/2026
Merged by: @crobibero

Base: release-10.11.z ← Head: more-strict-roles

📝 Commits (1)

3de5fa5 Be more strict about PersonType assignments

📊 Changes

5 files changed (+8 additions, -15 deletions)

View changed files

📝 MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieProvider.cs (+1 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeProvider.cs (+1 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonProvider.cs (+1 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesProvider.cs (+1 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/TmdbUtils.cs (+4 -3)

📄 Description

TMDB returns a ton of different crew/cast persons which can contain the different job denominations. E.g. director would be assigned to all of these:

First Assistant Director
Second Assistant Director
Assistant Art Director
Casting Director

But for our presentation use cases we only need the actual director. If we want to expose the other ones too, we should introduce proper subtypes.

Changes

Do not match with contains but check for equality

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15872 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 12/27/2025 **Status:** ✅ Merged **Merged:** 1/17/2026 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `more-strict-roles` --- ### 📝 Commits (1) - [`3de5fa5`](https://github.com/jellyfin/jellyfin/commit/3de5fa54c0dd13ddd946f25742e0bba8b024b5a2) Be more strict about PersonType assignments ### 📊 Changes **5 files changed** (+8 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieProvider.cs` (+1 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeProvider.cs` (+1 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonProvider.cs` (+1 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesProvider.cs` (+1 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TmdbUtils.cs` (+4 -3) </details> ### 📄 Description TMDB returns a ton of different crew/cast persons which can contain the different job denominations. E.g. director would be assigned to all of these: - First Assistant Director - Second Assistant Director - Assistant Art Director - Casting Director But for our presentation use cases we only need the actual director. If we want to expose the other ones too, we should introduce proper subtypes. **Changes** * Do not match with `contains` but check for equality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:29:55 +03:00

OVERLORD closed this issue

2026-02-07 07:29:58 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14445