[PR #15807] [MERGED] Enforce more strict webm check #14424

Closed
opened 2026-02-07 07:29:35 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15807
Author: @gnattu
Created: 12/16/2025
Status: Merged
Merged: 12/20/2025
Merged by: @crobibero

Base: release-10.11.zHead: more-strict-webm-probing


📝 Commits (2)

  • 879706a Enforce more strict webm check
  • 820b5f9 fix missing test file

📊 Changes

3 files changed (+155 additions, -3 deletions)

View changed files

📝 MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs (+6 -3)
📝 tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs (+12 -0)
tests/Jellyfin.MediaEncoding.Tests/Test Data/Probing/video_web_like_mkv_with_subtitle.json (+137 -0)

📄 Description

The webm spec only supports video and video streams, and other type of streams in the container should disqualify its webm container type and be treated as mkv.

Some tools might allow users to add subtitle streams to webm and still claim it is webm, but such files are not guranteed to play directly everywhere, and the actuall support is implementation specific.

With the advent of the (unreliable) native mkv support in firefox, this will be required to properly trigger remux for such files.

Changes

Issues

Fixes https://github.com/jellyfin/jellyfin-web/issues/7430


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15807 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/20/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `more-strict-webm-probing` --- ### 📝 Commits (2) - [`879706a`](https://github.com/jellyfin/jellyfin/commit/879706a9013bdfcd9d774126ec8c298c9fa2fb03) Enforce more strict webm check - [`820b5f9`](https://github.com/jellyfin/jellyfin/commit/820b5f983ddf4fac142209daddbccce26737cd94) fix missing test file ### 📊 Changes **3 files changed** (+155 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs` (+6 -3) 📝 `tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs` (+12 -0) ➕ `tests/Jellyfin.MediaEncoding.Tests/Test Data/Probing/video_web_like_mkv_with_subtitle.json` (+137 -0) </details> ### 📄 Description The webm spec only supports video and video streams, and other type of streams in the container should disqualify its webm container type and be treated as mkv. Some tools might allow users to add subtitle streams to webm and still claim it is webm, but such files are not guranteed to play directly everywhere, and the actuall support is implementation specific. With the advent of the (unreliable) native mkv support in firefox, this will be required to properly trigger remux for such files. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes https://github.com/jellyfin/jellyfin-web/issues/7430 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:29:35 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14424