[PR #15752] [MERGED] Fix case sensitivity edge case #14411

Closed
opened 2026-02-07 07:29:23 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15752
Author: @Collin-Swish
Created: 12/9/2025
Status: Merged
Merged: 12/12/2025
Merged by: @Bond-009

Base: release-10.11.zHead: fix-name-case-insensitivity


📝 Commits (1)

  • 2e8d9a3 Fix case sensitivity edge case

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Users/UserManager.cs (+1 -1)

📄 Description

Summary

Both UserController.UpdateUser and UserManager.RenameUser compare the new username with the old username. UpdateUser checked for case sensitive inequality while RenameUser was case insensitive. This led to an edge case where the username change would lead to an incomplete request if the only difference was the character case. e.g collin to Collin. This left the client unresponsive while it waited for a server request that would never come.

Changes

Changed equality in UserManager.RenameUser from case insensitive to case sensitive.

Issues

Fixes #15417


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15752 **Author:** [@Collin-Swish](https://github.com/Collin-Swish) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.11.z` ← **Head:** `fix-name-case-insensitivity` --- ### 📝 Commits (1) - [`2e8d9a3`](https://github.com/jellyfin/jellyfin/commit/2e8d9a311b57c171b43ec999adf0f94a8fd6a177) Fix case sensitivity edge case ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Users/UserManager.cs` (+1 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> # Summary Both UserController.UpdateUser and UserManager.RenameUser compare the new username with the old username. UpdateUser checked for case sensitive inequality while RenameUser was case insensitive. This led to an edge case where the username change would lead to an incomplete request if the only difference was the character case. e.g collin to Collin. This left the client unresponsive while it waited for a server request that would never come. **Changes** <!-- Describe your changes here in 1-5 sentences. --> Changed equality in UserManager.RenameUser from case insensitive to case sensitive. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #15417 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:29:23 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14411