starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #15737] [CLOSED] Flip default ConfigureAwait value #14406

New Issue
Closed
opened 2026-02-07 07:29:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:29:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15737
Author: @MarkCiliaVincenti
Created: 12/6/2025
Status: ❌ Closed

Base: master ← Head: ConfigureAwait

📝 Commits (1)

  • f7ef155 Flip default ConfigureAwait value

📊 Changes

285 files changed (+2010 additions, -1943 deletions)

View changed files

📝 .editorconfig (+3 -3)
📝 Directory.Packages.props (+5 -3)
📝 Emby.Naming/Emby.Naming.csproj (+12 -2)
📝 Emby.Photos/Emby.Photos.csproj (+8 -1)
📝 Emby.Server.Implementations/ApplicationHost.cs (+1 -1)
📝 Emby.Server.Implementations/Chapters/ChapterManager.cs (+2 -2)
📝 Emby.Server.Implementations/Collections/CollectionManager.cs (+5 -5)
📝 Emby.Server.Implementations/Data/CleanDatabaseScheduledTask.cs (+7 -11)
📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+8 -1)
📝 Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs (+2 -3)
📝 Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs (+1 -1)
📝 Emby.Server.Implementations/HttpServer/Security/AuthService.cs (+1 -1)
📝 Emby.Server.Implementations/HttpServer/WebSocketConnection.cs (+12 -12)
📝 Emby.Server.Implementations/HttpServer/WebSocketManager.cs (+6 -6)
📝 Emby.Server.Implementations/IO/LibraryMonitor.cs (+1 -1)
📝 Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs (+3 -3)
📝 Emby.Server.Implementations/Library/ExternalDataManager.cs (+4 -4)
📝 Emby.Server.Implementations/Library/KeyframeManager.cs (+2 -2)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+25 -25)
📝 Emby.Server.Implementations/Library/LiveStreamHelper.cs (+7 -14)

...and 80 more files

📄 Description

Massive PR, I know.

But reading all the .ConfigureAwait(false) is so annoying.

This PR sets ConfigureAwait as default through a source generator.
It will also show errors if someone sets .ConfigureAwait(false) but no errors on .ConfigureAwait(true) in case this needs to be set to true.

Fully expecting this to be rejected because, I understand, such a big change and so many merge conflicts will happen, but I took a chance. The code looks much cleaner now.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15737 **Author:** [@MarkCiliaVincenti](https://github.com/MarkCiliaVincenti) **Created:** 12/6/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ConfigureAwait` --- ### 📝 Commits (1) - [`f7ef155`](https://github.com/jellyfin/jellyfin/commit/f7ef155772f6e47c29b8e28cda453fe29de0f7f5) Flip default ConfigureAwait value ### 📊 Changes **285 files changed** (+2010 additions, -1943 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+3 -3) 📝 `Directory.Packages.props` (+5 -3) 📝 `Emby.Naming/Emby.Naming.csproj` (+12 -2) 📝 `Emby.Photos/Emby.Photos.csproj` (+8 -1) 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+1 -1) 📝 `Emby.Server.Implementations/Chapters/ChapterManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Collections/CollectionManager.cs` (+5 -5) 📝 `Emby.Server.Implementations/Data/CleanDatabaseScheduledTask.cs` (+7 -11) 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+8 -1) 📝 `Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs` (+2 -3) 📝 `Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs` (+1 -1) 📝 `Emby.Server.Implementations/HttpServer/Security/AuthService.cs` (+1 -1) 📝 `Emby.Server.Implementations/HttpServer/WebSocketConnection.cs` (+12 -12) 📝 `Emby.Server.Implementations/HttpServer/WebSocketManager.cs` (+6 -6) 📝 `Emby.Server.Implementations/IO/LibraryMonitor.cs` (+1 -1) 📝 `Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs` (+3 -3) 📝 `Emby.Server.Implementations/Library/ExternalDataManager.cs` (+4 -4) 📝 `Emby.Server.Implementations/Library/KeyframeManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+25 -25) 📝 `Emby.Server.Implementations/Library/LiveStreamHelper.cs` (+7 -14) _...and 80 more files_ </details> ### 📄 Description Massive PR, I know. But reading all the .ConfigureAwait(false) is so annoying. This PR sets ConfigureAwait as default through a source generator. It will also show errors if someone sets .ConfigureAwait(false) but no errors on .ConfigureAwait(true) in case this needs to be set to true. Fully expecting this to be rejected because, I understand, such a big change and so many merge conflicts will happen, but I took a chance. The code looks much cleaner now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:29:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14406
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?