starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #15718] [MERGED] Library: Async the SaveImages function #14398

New Issue
Closed
opened 2026-02-07 07:29:13 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:29:13 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15718
Author: @luigi311
Created: 12/5/2025
Status: ✅ Merged
Merged: 12/13/2025
Merged by: @crobibero

Base: master ← Head: async_saveimage

📝 Commits (2)

  • 5303c0b Library: Async the SaveImages function
  • 3ff37f5 BaseItemRepository include context disposal

📊 Changes

3 files changed (+24 additions, -12 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+1 -1)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+22 -10)
📝 MediaBrowser.Controller/Persistence/IItemRepository.cs (+1 -1)

📄 Description

Changes
Change the SameImages database function to be async. Added a cancellation token but it is unused. Gonna work through converting the other functions to be async aswell and if its called at a higher level see if that can be converted to async, if not create a wrapper that can exist until the top layers are converted to async calls.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15718 **Author:** [@luigi311](https://github.com/luigi311) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/13/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `async_saveimage` --- ### 📝 Commits (2) - [`5303c0b`](https://github.com/jellyfin/jellyfin/commit/5303c0b05b2bdcf7a31b2655cd3c647e9cabced6) Library: Async the SaveImages function - [`3ff37f5`](https://github.com/jellyfin/jellyfin/commit/3ff37f57a8975033069f944e7f3a819fd738a626) BaseItemRepository include context disposal ### 📊 Changes **3 files changed** (+24 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+1 -1) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+22 -10) 📝 `MediaBrowser.Controller/Persistence/IItemRepository.cs` (+1 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Change the SameImages database function to be async. Added a cancellation token but it is unused. Gonna work through converting the other functions to be async aswell and if its called at a higher level see if that can be converted to async, if not create a wrapper that can exist until the top layers are converted to async calls. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:29:13 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?