[PR #15698] [MERGED] Fix stack overflow during scan (#15000) #14396

New Issue

OVERLORD · 2026-02-07T07:29:11+03:00

OVERLORD commented

2026-02-07 07:29:11 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15698
Author: @myzhysz
Created: 12/2/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @crobibero

Base: release-10.11.z ← Head: fix-15000

📝 Commits (1)

debb850 Fix stack overflow (#15000)

📊 Changes

1 file changed (+6 additions, -27 deletions)

View changed files

📝 MediaBrowser.Controller/LibraryTaskScheduler/LimitedConcurrencyLibraryScheduler.cs (+6 -27)

📄 Description

In function MediaBrowser.Controller.LibraryTaskScheduler.Enqueue, if we enter the "we are in a nested loop" block, the logic try get a item from _tasks, making function Enqueue not process the file in subfolder, but start from a new folder which increase Call Stack. This make the length of Call Stack is not depends on the depth of filesystem, but the count of subfolders. Therefore, if there are lots of subfolders, the Call Stack will exceed a certain limit and cause Stack Overflow.

Changes
When _deadlockDetector.Value is not null, using existed ForceSequentialOperation.

Issues
Fixes https://github.com/jellyfin/jellyfin/issues/15000

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15698 **Author:** [@myzhysz](https://github.com/myzhysz) **Created:** 12/2/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `fix-15000` --- ### 📝 Commits (1) - [`debb850`](https://github.com/jellyfin/jellyfin/commit/debb85011e147f055ed60467ef45c7217def5d2c) Fix stack overflow (#15000) ### 📊 Changes **1 file changed** (+6 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/LibraryTaskScheduler/LimitedConcurrencyLibraryScheduler.cs` (+6 -27) </details> ### 📄 Description In function MediaBrowser.Controller.LibraryTaskScheduler.Enqueue, if we enter the "we are in a nested loop" block, the logic try get a item from _tasks, making function Enqueue not process the file in subfolder, but start from a new folder which increase Call Stack. This make the length of Call Stack is not depends on the depth of filesystem, but the count of subfolders. Therefore, if there are lots of subfolders, the Call Stack will exceed a certain limit and cause Stack Overflow. **Changes** When _deadlockDetector.Value is not null, using existed ForceSequentialOperation. **Issues** Fixes https://github.com/jellyfin/jellyfin/issues/15000 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:29:11 +03:00

OVERLORD closed this issue

2026-02-07 07:29:12 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14396