starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #15659] [MERGED] Fix thumbnails never deletes from temp folder ( issue #15629 ) #14379

New Issue
Closed
opened 2026-02-07 07:28:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:28:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15659
Author: @liszto
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/6/2025
Merged by: @crobibero

Base: release-10.11.z ← Head: fix-skia-tempFileDeletion

📝 Commits (1)

📊 Changes

1 file changed (+58 additions, -28 deletions)

View changed files

📝 src/Jellyfin.Drawing.Skia/SkiaEncoder.cs (+58 -28)

📄 Description

Changes
Compare path returned by NormalizePath.
Add a try/finally to dispose SKCodec and if the path is a temporary one,
I try to delete the file at path if exists.

Issues
https://github.com/jellyfin/jellyfin/issues/15629

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15659 **Author:** [@liszto](https://github.com/liszto) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `fix-skia-tempFileDeletion` --- ### 📝 Commits (1) - [`c4ea1a8`](https://github.com/jellyfin/jellyfin/commit/c4ea1a811ceefc6f71986ce9ef092aa5405909fe) Fix issue #15629 -> https://github.com/jellyfin/jellyfin/issues/15629 ### 📊 Changes **1 file changed** (+58 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+58 -28) </details> ### 📄 Description <!-- Fix thumbnails never deletes from temp folder --> **Changes** Compare path returned by NormalizePath. Add a try/finally to dispose SKCodec and if the path is a temporary one, I try to delete the file at path if exists. **Issues** https://github.com/jellyfin/jellyfin/issues/15629 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:28:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?