starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #15651] [CLOSED] Fix WebSocketManager client IP resolution #14374

New Issue
Closed
opened 2026-02-07 07:28:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:28:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15651
Author: @WWWesten
Created: 11/27/2025
Status: ❌ Closed

Base: master ← Head: fix-remote-ip

📝 Commits (5)

  • 595b79d WebSocketManager: use clientIpAddress instead of Connection.RemoteIpAddress
  • 4c0fa7c Use INetworkManager in WebSocketManager for client IP resolution
  • 9c940b7 Add references for ServerOptions
  • 74f2ed2 WebSocketManager: add INetworkManager and ServerOptions support
  • 4e4e462 Emby.Server.Implementations: add Logging.Abstractions reference

📊 Changes

2 files changed (+35 additions, -9 deletions)

View changed files

📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+3 -0)
📝 Emby.Server.Implementations/HttpServer/WebSocketManager.cs (+32 -9)

📄 Description

Changes

  • Inject INetworkManager into WebSocketManager
  • Resolve client IP using RemoteIPHeader with KnownProxies fallback
  • Replace direct Connection.RemoteIpAddress usage with clientIpAddress

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15651 **Author:** [@WWWesten](https://github.com/WWWesten) **Created:** 11/27/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-remote-ip` --- ### 📝 Commits (5) - [`595b79d`](https://github.com/jellyfin/jellyfin/commit/595b79d3bddf2e23993b9c8918de8ea700cdc0c3) WebSocketManager: use clientIpAddress instead of Connection.RemoteIpAddress - [`4c0fa7c`](https://github.com/jellyfin/jellyfin/commit/4c0fa7ccc0f410acb8974c61df238e090d119130) Use INetworkManager in WebSocketManager for client IP resolution - [`9c940b7`](https://github.com/jellyfin/jellyfin/commit/9c940b74921da78ae4b2507aedb3f6a6bb64de34) Add references for ServerOptions - [`74f2ed2`](https://github.com/jellyfin/jellyfin/commit/74f2ed2a495638c423ef5e081629da7efb6a1489) WebSocketManager: add INetworkManager and ServerOptions support - [`4e4e462`](https://github.com/jellyfin/jellyfin/commit/4e4e4620f8a4f50d2b0903c4abd9eb9ffac2ab9a) Emby.Server.Implementations: add Logging.Abstractions reference ### 📊 Changes **2 files changed** (+35 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+3 -0) 📝 `Emby.Server.Implementations/HttpServer/WebSocketManager.cs` (+32 -9) </details> ### 📄 Description **Changes** - Inject INetworkManager into WebSocketManager - Resolve client IP using RemoteIPHeader with KnownProxies fallback - Replace direct Connection.RemoteIpAddress usage with clientIpAddress **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:28:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?