[PR #15638] [MERGED] Remove special client behavior for API response fields #14370

Closed
opened 2026-02-07 07:28:44 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15638
Author: @nielsvanvelzen
Created: 11/27/2025
Status: Merged
Merged: 11/30/2025
Merged by: @crobibero

Base: masterHead: no-client-dto-behavior


📝 Commits (1)

  • be8002c Remove DtoExtensions.AddClientFields

📊 Changes

19 files changed (+22 additions, -110 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ArtistsController.cs (+1 -3)
📝 Jellyfin.Api/Controllers/CollectionController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/GenresController.cs (+1 -3)
📝 Jellyfin.Api/Controllers/InstantMixController.cs (+0 -7)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+0 -2)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+5 -6)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+2 -9)
📝 Jellyfin.Api/Controllers/MoviesController.cs (+1 -2)
📝 Jellyfin.Api/Controllers/MusicGenresController.cs (+1 -2)
📝 Jellyfin.Api/Controllers/PersonsController.cs (+1 -3)
📝 Jellyfin.Api/Controllers/PlaylistsController.cs (+0 -1)
📝 Jellyfin.Api/Controllers/StudiosController.cs (+1 -2)
📝 Jellyfin.Api/Controllers/SuggestionsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/TvShowsController.cs (+0 -4)
📝 Jellyfin.Api/Controllers/UserLibraryController.cs (+5 -6)
📝 Jellyfin.Api/Controllers/UserViewsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/VideosController.cs (+0 -1)
📝 Jellyfin.Api/Controllers/YearsController.cs (+1 -3)
📝 Jellyfin.Api/Extensions/DtoExtensions.cs (+0 -53)

📄 Description

Clients are responsible for collection the item fields they need, the server shouldn't decide that for them.

Note that Android TV hasn't used the name "androidtv" (without space) for quite some time now. The only clients this might affect are Kodi/Roku, in which case we'll need to update them before 10.12.

Changes

  • Remove DtoExtensions.AddClientFields

Issues


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15638 **Author:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Created:** 11/27/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `no-client-dto-behavior` --- ### 📝 Commits (1) - [`be8002c`](https://github.com/jellyfin/jellyfin/commit/be8002c6d16cea995057199663ec2e8b3c25f090) Remove DtoExtensions.AddClientFields ### 📊 Changes **19 files changed** (+22 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+1 -3) 📝 `Jellyfin.Api/Controllers/CollectionController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/GenresController.cs` (+1 -3) 📝 `Jellyfin.Api/Controllers/InstantMixController.cs` (+0 -7) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+0 -2) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+5 -6) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+2 -9) 📝 `Jellyfin.Api/Controllers/MoviesController.cs` (+1 -2) 📝 `Jellyfin.Api/Controllers/MusicGenresController.cs` (+1 -2) 📝 `Jellyfin.Api/Controllers/PersonsController.cs` (+1 -3) 📝 `Jellyfin.Api/Controllers/PlaylistsController.cs` (+0 -1) 📝 `Jellyfin.Api/Controllers/StudiosController.cs` (+1 -2) 📝 `Jellyfin.Api/Controllers/SuggestionsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/TvShowsController.cs` (+0 -4) 📝 `Jellyfin.Api/Controllers/UserLibraryController.cs` (+5 -6) 📝 `Jellyfin.Api/Controllers/UserViewsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+0 -1) 📝 `Jellyfin.Api/Controllers/YearsController.cs` (+1 -3) 📝 `Jellyfin.Api/Extensions/DtoExtensions.cs` (+0 -53) </details> ### 📄 Description Clients are responsible for collection the item fields they need, the server shouldn't decide that for them. Note that Android TV hasn't used the name "androidtv" (without space) for quite some time now. The only clients this might affect are Kodi/Roku, in which case we'll need to update them before 10.12. **Changes** - Remove DtoExtensions.AddClientFields **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:28:44 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14370