starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #15645] [CLOSED] Update WebSocketManager.cs Fix RemoteIPHeader for WebSocket connections #14369

New Issue
Closed
opened 2026-02-07 07:28:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:28:44 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15645
Author: @WWWesten
Created: 11/27/2025
Status: ❌ Closed

Base: master ← Head: remoteip

📝 Commits (1)

  • 5bc9ecc Update WebSocketManager.cs Fix RemoteIPHeader for WebSocket connections

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/WebSocketManager.cs (+5 -3)

📄 Description

Fix RemoteIPHeader for WebSocket connections

Changes
Replaced usage of context.Connection.RemoteIpAddress in WebSocketManager with NetworkManager.GetRemoteIp(context.Request).
This ensures that RemoteIPHeader and KnownProxies settings are respected for WebSocket connections.
As a result, clients behind reverse proxies will now show their real IP addresses instead of the proxy IP.

Issues
No related issue filed. Can be linked later if maintainers request.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15645 **Author:** [@WWWesten](https://github.com/WWWesten) **Created:** 11/27/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remoteip` --- ### 📝 Commits (1) - [`5bc9ecc`](https://github.com/jellyfin/jellyfin/commit/5bc9ecc8c515b637be61b30156446e516d329110) Update WebSocketManager.cs Fix RemoteIPHeader for WebSocket connections ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/WebSocketManager.cs` (+5 -3) </details> ### 📄 Description Fix RemoteIPHeader for WebSocket connections **Changes** Replaced usage of context.Connection.RemoteIpAddress in WebSocketManager with NetworkManager.GetRemoteIp(context.Request). This ensures that RemoteIPHeader and KnownProxies settings are respected for WebSocket connections. As a result, clients behind reverse proxies will now show their real IP addresses instead of the proxy IP. **Issues** No related issue filed. Can be linked later if maintainers request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:28:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?