[PR #15592] [CLOSED] Expand folder IDs in SyncPlay SetPlayQueue so "Play all from here" works for mixed folders (Fixes #15396) #14357

New Issue

OVERLORD · 2026-02-07T07:28:33+03:00

OVERLORD commented

2026-02-07 07:28:33 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15592
Author: @audrey-inglish
Created: 11/21/2025
Status: ❌ Closed

Base: master ← Head: fix-#15396

📝 Commits (3)

ebdb7ba Implement failing test
c94cfe6 Expand queue to handle subfolders, passing test
618e970 implement characterization tests

📊 Changes

2 files changed (+476 additions, -6 deletions)

View changed files

📝 Emby.Server.Implementations/SyncPlay/Group.cs (+48 -6)
➕ tests/Jellyfin.Server.Implementations.Tests/SyncPlay/GroupSetPlayQueueTests.cs (+428 -0)

📄 Description

Changes
Fixes the bug described in #15396 where "Play all from here" in Music Videos (and similar libraries) fails to start if the selected folder contains a mix of playable files and subfolders.

Server now expands folder IDs into their playable children when building a play queue, and remaps the playing index accordingly so clients no longer end up with folders in the queue.

Adds unit tests that demonstrate the intended behavior (and failed state prior to the fix).

Issues
Fixes #15396

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15592 **Author:** [@audrey-inglish](https://github.com/audrey-inglish) **Created:** 11/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-#15396` --- ### 📝 Commits (3) - [`ebdb7ba`](https://github.com/jellyfin/jellyfin/commit/ebdb7ba579f98e65b61f1b2561a20db07a849042) Implement failing test - [`c94cfe6`](https://github.com/jellyfin/jellyfin/commit/c94cfe6ff39f3397d490f4fe39d0538dbdd57fc3) Expand queue to handle subfolders, passing test - [`618e970`](https://github.com/jellyfin/jellyfin/commit/618e9700ad16d30c904cd30d0fa6918c59170bb1) implement characterization tests ### 📊 Changes **2 files changed** (+476 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/SyncPlay/Group.cs` (+48 -6) ➕ `tests/Jellyfin.Server.Implementations.Tests/SyncPlay/GroupSetPlayQueueTests.cs` (+428 -0) </details> ### 📄 Description **Changes** Fixes the bug described in #15396 where "Play all from here" in Music Videos (and similar libraries) fails to start if the selected folder contains a mix of playable files and subfolders. Server now expands folder IDs into their playable children when building a play queue, and remaps the playing index accordingly so clients no longer end up with folders in the queue. Adds unit tests that demonstrate the intended behavior (and failed state prior to the fix). **Issues** Fixes #15396 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:28:33 +03:00

OVERLORD closed this issue

2026-02-07 07:28:35 +03:00

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14357