starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #15501] [MERGED] Fix .ignore handling for directories #14332

New Issue
Closed
opened 2026-02-07 07:28:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:28:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15501
Author: @theguymadmax
Created: 11/13/2025
Status: ✅ Merged
Merged: 11/14/2025
Merged by: @crobibero

Base: release-10.11.z ← Head: fix-.ignore-handling-for-directories

📝 Commits (1)

  • d5e8d5d Fix .ignore handling for directories

📊 Changes

1 file changed (+39 additions, -58 deletions)

View changed files

📝 Emby.Server.Implementations/Library/DotIgnoreIgnoreRule.cs (+39 -58)

📄 Description

Directories listed in .ignore (e.g., specials/) hid their contents but not the folder itself, contrary to the documentation.

Changes

  • Fix handling for directories (e.g., specials/) listed in the .ignore file
  • Simplify FindIgnoreFile to use a loop
  • Use a single IsWindows flag for OS detection
  • Move ignore rule logic to CheckIgnoreRules
  • Clean up reading of .ignore file content

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15501 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 11/13/2025 **Status:** ✅ Merged **Merged:** 11/14/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `fix-.ignore-handling-for-directories` --- ### 📝 Commits (1) - [`d5e8d5d`](https://github.com/jellyfin/jellyfin/commit/d5e8d5db5d38903954204385fb6a7dcccf2247f7) Fix .ignore handling for directories ### 📊 Changes **1 file changed** (+39 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/DotIgnoreIgnoreRule.cs` (+39 -58) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> Directories listed in .ignore (e.g., specials/) hid their contents but not the folder itself, contrary to the [documentation](https://github.com/jellyfin/jellyfin.org/pull/1650). **Changes** <!-- Describe your changes here in 1-5 sentences. --> - Fix handling for directories (e.g., specials/) listed in the .ignore file - Simplify `FindIgnoreFile` to use a loop - Use a single `IsWindows` flag for OS detection - Move ignore rule logic to `CheckIgnoreRules` - Clean up reading of .ignore file content --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:28:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14332
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?