starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #15446] [MERGED] Fix AncestorIds not migrating #14315

New Issue
Closed
opened 2026-02-07 07:27:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:27:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15446
Author: @theguymadmax
Created: 11/9/2025
Status: ✅ Merged
Merged: 11/9/2025
Merged by: @crobibero

Base: release-10.11.z ← Head: fix-baseitemid-migration

📝 Commits (1)

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs (+0 -2)

📄 Description

Clearing baseItemIds in the move people migration causes the AncestorId and Chapter migrations to come back with 0 items.

Changes
Don't clear baseItemIds

Issues
Fixes #14900
Fixes #15028
And chapter migration

Before:

[2025-11-09 03:04:49.345 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving Chapters"
[2025-11-09 03:04:49.346 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading Chapters"
[2025-11-09 03:04:49.516 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading Chapters" took '00:00:00.1697364'
[2025-11-09 03:04:49.518 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 0 Chapters entries"
[2025-11-09 03:04:49.520 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 0 Chapters entries" took '00:00:00.0019643'
[2025-11-09 03:04:49.522 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving Chapters" took '00:00:00.1769655'
[2025-11-09 03:04:49.524 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving AncestorIds"
[2025-11-09 03:04:49.526 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading AncestorIds"
[2025-11-09 03:04:49.740 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading AncestorIds" took '00:00:00.2144310'
[2025-11-09 03:04:49.742 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 0 AncestorId entries"
[2025-11-09 03:04:49.743 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 0 AncestorId entries" took '00:00:00.0011256'
[2025-11-09 03:04:49.745 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving AncestorIds" took '00:00:00.2204243'
[2025-11-09 03:04:49.746 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Migration of the Library.db done.

After:

[2025-11-09 02:37:16.169 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving Chapters"
[2025-11-09 02:37:16.169 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading Chapters"
[2025-11-09 02:37:16.680 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading Chapters" took '00:00:00.5116349'
[2025-11-09 02:37:16.690 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 68262 Chapters entries"
[2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 68262 Chapters entries" took '00:00:01.9555500'
[2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving Chapters" took '00:00:02.4771938'
[2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving AncestorIds"
[2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading AncestorIds"
[2025-11-09 02:37:19.274 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading AncestorIds" took '00:00:00.6277471'
[2025-11-09 02:37:19.277 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 97321 AncestorId entries"
[2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 97321 AncestorId entries" took '00:00:03.1121741'
[2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving AncestorIds" took '00:00:03.7434218'
[2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Migration of the Library.db done.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15446 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 11/9/2025 **Status:** ✅ Merged **Merged:** 11/9/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.11.z` ← **Head:** `fix-baseitemid-migration` --- ### 📝 Commits (1) - [`ba9b25d`](https://github.com/jellyfin/jellyfin/commit/ba9b25d9809c90373e65792b3de67e5575fdf6d2) Don't clear baseitemids ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs` (+0 -2) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> Clearing baseItemIds in the move people migration causes the [AncestorId](https://github.com/jellyfin/jellyfin/blob/0598c6eaf6c7bdafaaf6c6f6518a50f3444dbc69/Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs#L447) and Chapter migrations to come back with 0 items. **Changes** Don't clear baseItemIds **Issues** Fixes #14900 Fixes #15028 And chapter migration Before: ``` [2025-11-09 03:04:49.345 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving Chapters" [2025-11-09 03:04:49.346 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading Chapters" [2025-11-09 03:04:49.516 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading Chapters" took '00:00:00.1697364' [2025-11-09 03:04:49.518 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 0 Chapters entries" [2025-11-09 03:04:49.520 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 0 Chapters entries" took '00:00:00.0019643' [2025-11-09 03:04:49.522 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving Chapters" took '00:00:00.1769655' [2025-11-09 03:04:49.524 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving AncestorIds" [2025-11-09 03:04:49.526 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading AncestorIds" [2025-11-09 03:04:49.740 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading AncestorIds" took '00:00:00.2144310' [2025-11-09 03:04:49.742 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 0 AncestorId entries" [2025-11-09 03:04:49.743 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 0 AncestorId entries" took '00:00:00.0011256' [2025-11-09 03:04:49.745 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving AncestorIds" took '00:00:00.2204243' [2025-11-09 03:04:49.746 -05:00] [INF] [9] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Migration of the Library.db done. ``` After: ``` [2025-11-09 02:37:16.169 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving Chapters" [2025-11-09 02:37:16.169 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading Chapters" [2025-11-09 02:37:16.680 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading Chapters" took '00:00:00.5116349' [2025-11-09 02:37:16.690 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 68262 Chapters entries" [2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 68262 Chapters entries" took '00:00:01.9555500' [2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving Chapters" took '00:00:02.4771938' [2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Moving AncestorIds" [2025-11-09 02:37:18.646 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Loading AncestorIds" [2025-11-09 02:37:19.274 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Loading AncestorIds" took '00:00:00.6277471' [2025-11-09 02:37:19.277 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Start "Saving 97321 AncestorId entries" [2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Saving 97321 AncestorId entries" took '00:00:03.1121741' [2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: "Moving AncestorIds" took '00:00:03.7434218' [2025-11-09 02:37:22.389 -05:00] [INF] [7] Jellyfin.Server.Migrations.Routines.MigrateLibraryDb: Migration of the Library.db done. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:27:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14315
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?