[PR #15250] Add CI format check #14262

New Issue

OVERLORD · 2026-02-07T07:27:01+03:00

OVERLORD commented

2026-02-07 07:27:01 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15250
Author: @jakobkukla
Created: 10/27/2025
Status: 🔄 Open

Base: master ← Head: ci-format

📝 Commits (3)

20d2601 Run tree-wide dotnet format
b2f081d Fix StyleCop pattern matching whitespace false-positive
d18cca6 Add CI format check

📊 Changes

80 files changed (+600 additions, -570 deletions)

View changed files

➕ .github/workflows/ci-format.yml (+25 -0)
📝 Emby.Naming/ExternalFiles/ExternalPathParser.cs (+1 -1)
📝 Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Localization/LocalizationManager.cs (+2 -2)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/MediaSegmentExtractionTask.cs (+1 -1)
📝 Emby.Server.Implementations/Session/SessionManager.cs (+1 -1)
📝 Emby.Server.Implementations/SystemManager.cs (+5 -5)
📝 Jellyfin.Api/Controllers/AudioController.cs (+12 -12)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+38 -38)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/UniversalAudioController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/UserViewsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/VideosController.cs (+12 -12)
📝 Jellyfin.Api/Extensions/DtoExtensions.cs (+2 -2)
📝 Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs (+5 -5)
📝 Jellyfin.Api/Models/SystemInfoDtos/LibraryStorageDto.cs (+1 -1)
📝 Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs (+3 -3)
📝 Jellyfin.Server.Implementations/Item/PeopleRepository.cs (+4 -4)

...and 60 more files

📄 Description

Changes
Add a CI format check. The job runs dotnet format --verify-no-change which ensures the style rules in .editorconfig are met. Also applied a tree-wide format and had to work around a StyleCop false-positve bug.

To fix reported formatting errors locally, run dotnet format (which is part of the SDK) or use an IDE that respects .editorconfig to do it for you (like Visual Studio and VS Code).

A failed job looks like this:

Issues

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15250 **Author:** [@jakobkukla](https://github.com/jakobkukla) **Created:** 10/27/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `ci-format` --- ### 📝 Commits (3) - [`20d2601`](https://github.com/jellyfin/jellyfin/commit/20d2601dfe4472ede436503035bcb0438c87540a) Run tree-wide dotnet format - [`b2f081d`](https://github.com/jellyfin/jellyfin/commit/b2f081d50191e48328686807cdc3b6ed6337958e) Fix StyleCop pattern matching whitespace false-positive - [`d18cca6`](https://github.com/jellyfin/jellyfin/commit/d18cca604bb065247fba582a9c1db3fab002d55a) Add CI format check ### 📊 Changes **80 files changed** (+600 additions, -570 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/ci-format.yml` (+25 -0) 📝 `Emby.Naming/ExternalFiles/ExternalPathParser.cs` (+1 -1) 📝 `Emby.Server.Implementations/AppBase/BaseConfigurationManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Localization/LocalizationManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/MediaSegmentExtractionTask.cs` (+1 -1) 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/SystemManager.cs` (+5 -5) 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+12 -12) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+38 -38) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/UniversalAudioController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/UserViewsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+12 -12) 📝 `Jellyfin.Api/Extensions/DtoExtensions.cs` (+2 -2) 📝 `Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs` (+5 -5) 📝 `Jellyfin.Api/Models/SystemInfoDtos/LibraryStorageDto.cs` (+1 -1) 📝 `Jellyfin.Server.Implementations/Events/Consumers/Session/PlaybackStopLogger.cs` (+3 -3) 📝 `Jellyfin.Server.Implementations/Item/PeopleRepository.cs` (+4 -4) _...and 60 more files_ </details> ### 📄 Description  **Changes** Add a CI format check. The job runs `dotnet format --verify-no-change` which ensures the style rules in `.editorconfig` are met. Also applied a tree-wide format and had to work around a StyleCop false-positve bug. To fix reported formatting errors locally, run `dotnet format` (which is part of the SDK) or use an IDE that respects `.editorconfig` to do it for you (like Visual Studio and VS Code). A failed job looks like this: <img width="2480" height="1884" alt="failed-ci" src="https://github.com/user-attachments/assets/0be8a682-f4be-4519-8a29-d99782874baf" /> **Issues**  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:27:01 +03:00

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14262