starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14991] [MERGED] Fix contributing artist query #14213

New Issue
Closed
opened 2026-02-07 07:26:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:26:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14991
Author: @theguymadmax
Created: 10/13/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @crobibero

Base: master ← Head: fix-contributing-artists

📝 Commits (2)

📊 Changes

2 files changed (+40 additions, -2 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+13 -2)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs (+27 -0)

📄 Description

The ContributingArtistIds query included items where the artist appeared as both a contributing and album artist, without properly excluding the latter.

Changes

  • Filter items where the artist appears as a contributing artist
  • Explicitly exclude items where the same artist also appears as an album artist
  • Update ArtistIds filter to check both ItemValueType.Artist and ItemValueType.AlbumArtist
  • Added WhereReferencedItemMultipleTypes helper method

Issues
Fixes #14980

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14991 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 10/13/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-contributing-artists` --- ### 📝 Commits (2) - [`6067360`](https://github.com/jellyfin/jellyfin/commit/60673602ed419ebbe4afd903f874f0b0dec5ab4a) Fix contributing artist query - [`1a182a5`](https://github.com/jellyfin/jellyfin/commit/1a182a5e6374c03c0d184af4659b057bd7d5696b) Update ArtistIds ### 📊 Changes **2 files changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+13 -2) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs` (+27 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> The `ContributingArtistIds` query included items where the artist appeared as both a contributing and album artist, without properly excluding the latter. **Changes** - Filter items where the artist appears as a contributing artist - Explicitly exclude items where the same artist also appears as an album artist - Update `ArtistIds` filter to check both `ItemValueType.Artist` and `ItemValueType.AlbumArtist` - Added `WhereReferencedItemMultipleTypes` helper method **Issues** Fixes #14980 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:26:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?