starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14993] [MERGED] Fix exception when saving user data to NFO files #14212

New Issue
Closed
opened 2026-02-07 07:26:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:26:17 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14993
Author: @theguymadmax
Created: 10/13/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @crobibero

Base: master ← Head: nfo-watch-data-fix

📝 Commits (2)

  • f414f43 Fix NFO user data save during metadata import
  • c5061e5 Apply review suggestions

📊 Changes

1 file changed (+15 additions, -3 deletions)

View changed files

📝 MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs (+15 -3)

📄 Description

Changes

Fixed an exception caused during metadata import when save watch data to NFO was enabled. The NFO parser now checks if an item has been saved to the database before attempting to save user data.

Issues

Fixes #14534
Fixes #14507

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14993 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 10/13/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `nfo-watch-data-fix` --- ### 📝 Commits (2) - [`f414f43`](https://github.com/jellyfin/jellyfin/commit/f414f43f58701c86ed368f7122a12ba1e8d26915) Fix NFO user data save during metadata import - [`c5061e5`](https://github.com/jellyfin/jellyfin/commit/c5061e55c645804f2b8626c29a927547dea2950c) Apply review suggestions ### 📊 Changes **1 file changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs` (+15 -3) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Fixed an exception caused during metadata import when save watch data to NFO was enabled. The NFO parser now checks if an item has been saved to the database before attempting to save user data. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #14534 Fixes #14507 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:26:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?