[PR #14851] [MERGED] Fixing the UFID field value giving a warning and not being correctly processed #14150

Closed
opened 2026-02-07 07:25:11 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14851
Author: @teblam
Created: 9/24/2025
Status: Merged
Merged: 9/26/2025
Merged by: @crobibero

Base: masterHead: development


📝 Commits (2)

  • 89a0b65 Fixing the UFID field value giving a warning and not being correctly processed
  • bf7bbdb Fixing the UFID field value with proper sanitization

📊 Changes

1 file changed (+22 additions, -3 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+22 -3)

📄 Description

Unlike what is specified by the error message: "Audio file {File} contains a null character in its tag, but this is not allowed by its tagging standard. All characters after the null char will be discarded. Please fix your file", the ID3v2.4 standard allows and actually requires the use of the null character to terminate strings for certain frames like UFID frames, see: https://id3.org/id3v2.4.0-frames

My solution simply skips the sanitization of the UFID Field. I don't think there should be any problems posed by the lack of the usage of the TryGetSanitizedAdditionalFields method, as it pretty much only truncates the tags at the position of a null character, which is undesired here.

I have tested my fix with files that I identified with MusicBrainz Picard and have found it successful: instead of outputting "http://musicbrainz.org" in the "ID MusicBrainz Recording" in Jellyfin metadata, it outputs the correct ID and doesn't give an error anymore.

Changes
Gets the raw UFID value and doesn't sanitize it

Issues
Fixes #14844


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14851 **Author:** [@teblam](https://github.com/teblam) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `development` --- ### 📝 Commits (2) - [`89a0b65`](https://github.com/jellyfin/jellyfin/commit/89a0b65e2be1e7090e0ca8198f7830f95252dbe9) Fixing the UFID field value giving a warning and not being correctly processed - [`bf7bbdb`](https://github.com/jellyfin/jellyfin/commit/bf7bbdb7f885f4d5935114ff5c9355a4fb3bb7b7) Fixing the UFID field value with proper sanitization ### 📊 Changes **1 file changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+22 -3) </details> ### 📄 Description Unlike what is specified by the error message: "Audio file {File} contains a null character in its tag, but this is not allowed by its tagging standard. All characters after the null char will be discarded. Please fix your file", the ID3v2.4 standard allows and actually requires the use of the null character to terminate strings for certain frames like UFID frames, see: https://id3.org/id3v2.4.0-frames My solution simply skips the sanitization of the UFID Field. I don't think there should be any problems posed by the lack of the usage of the TryGetSanitizedAdditionalFields method, as it pretty much only truncates the tags at the position of a null character, which is undesired here. I have tested my fix with files that I identified with MusicBrainz Picard and have found it successful: instead of outputting "http://musicbrainz.org" in the "ID MusicBrainz Recording" in Jellyfin metadata, it outputs the correct ID and doesn't give an error anymore. **Changes** Gets the raw UFID value and doesn't sanitize it **Issues** Fixes #14844 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:25:11 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14150