starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14817] [MERGED] Make migration handle parent cleanup #14136

New Issue
Closed
opened 2026-02-07 07:24:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:24:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14817
Author: @JPVenson
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/19/2025
Merged by: @crobibero

Base: master ← Head: feature/MigrationParent

📝 Commits (3)

  • 43895e3 Make migration handle parent cleanup
  • 1f8b50f Remove speed improvement
  • fd13281 Update MigrateLibraryDb.cs

📊 Changes

1 file changed (+44 additions, -4 deletions)

View changed files

📝 Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs (+44 -4)

📄 Description

with #14795 the foregin key for parentId now gets actually enforced which wasn't the case previously where the ParentId could have pointed to an invalid or not existing element. This pr checks the ParentId of each migrated BaseItem to actually exist to prevent failing migrations

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14817 **Author:** [@JPVenson](https://github.com/JPVenson) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/19/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `feature/MigrationParent` --- ### 📝 Commits (3) - [`43895e3`](https://github.com/jellyfin/jellyfin/commit/43895e30e0d82272ce60ae7020d61d43fc094aca) Make migration handle parent cleanup - [`1f8b50f`](https://github.com/jellyfin/jellyfin/commit/1f8b50f48d59fdaab14ccbb518f46943ef322f34) Remove speed improvement - [`fd13281`](https://github.com/jellyfin/jellyfin/commit/fd13281409f982a0848edf1aec22a7db6d03ec0a) Update MigrateLibraryDb.cs ### 📊 Changes **1 file changed** (+44 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs` (+44 -4) </details> ### 📄 Description with #14795 the foregin key for parentId now gets actually enforced which wasn't the case previously where the ParentId could have pointed to an invalid or not existing element. This pr checks the ParentId of each migrated BaseItem to actually exist to prevent failing migrations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:24:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14136
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?