starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14764] [MERGED] Seal Emby.Naming.Video.StackResolver.StackMetadata to silence a compiler warning #14099

New Issue
Closed
opened 2026-02-07 07:24:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:24:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14764
Author: @varoonp123
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @Bond-009

Base: master ← Head: feature/StackResolverStackMetadataSealed

📝 Commits (1)

  • cbb569a Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence compiler warning

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Emby.Naming/Video/StackResolver.cs (+1 -1)

📄 Description

…
Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence a compiler warning

Changes
Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence a compiler warning

Issues
Fixes https://github.com/jellyfin/jellyfin/issues/2149 (though not entirely)

Note
I am a jellyfin self-hoster (great project btw!) looking to start contributing and started by running the tests while noticing a few compiler warnings. I thought I could start there. Since this is a private class and only internal to Emby.Naming.Video.StackResolver, preventing inheritance shouldn't break anything downstream. It doesn't seem that this class was explicitly designed with the idea that one might inherit from it See here. Apparently this might be more jit-friendly by avoiding "virtual-table" traversal/method-resolution. But mainly it silences one compiler warning.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14764 **Author:** [@varoonp123](https://github.com/varoonp123) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `feature/StackResolverStackMetadataSealed` --- ### 📝 Commits (1) - [`cbb569a`](https://github.com/jellyfin/jellyfin/commit/cbb569a277902d4c323e00ad0850444c3f63dd54) Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence compiler warning ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Video/StackResolver.cs` (+1 -1) </details> ### 📄 Description … Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence a compiler warning **Changes** Make private Emby.Naming.Video.StackResolver.StackMetadata sealed to silence a compiler warning **Issues** Fixes https://github.com/jellyfin/jellyfin/issues/2149 (though not entirely) **Note** I am a jellyfin self-hoster (great project btw!) looking to start contributing and started by running the tests while noticing a few compiler warnings. I thought I could start there. Since this is a private class and only internal to Emby.Naming.Video.StackResolver, preventing inheritance shouldn't break anything downstream. It doesn't seem that this class was explicitly designed with the idea that one might inherit from it [See here](https://learn.microsoft.com/en-us/archive/blogs/ericlippert/why-are-so-many-of-the-framework-classes-sealed). Apparently this [_might_ be more jit-friendly](https://github.com/dotnet/runtime/issues/49944) by avoiding "virtual-table" traversal/method-resolution. But mainly it silences one compiler warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:24:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?